ozone: unify GpuMemoryBufferFactoryOzoneNativePixmap in content/

ui/gl/gl_image_ozone_native_pixmap.h

Index: ui/gl/gl_image_ozone_native_pixmap.h
diff --git a/ui/gl/gl_image_ozone_native_pixmap.h b/ui/gl/gl_image_ozone_native_pixmap.h
new file mode 100644
index 0000000000000000000000000000000000000000..1124f7c2095c80951a846d513ce2a2e1bdbcf403
--- /dev/null
+++ b/ui/gl/gl_image_ozone_native_pixmap.h
@@ -0,0 +1,22 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef UI_GL_GL_IMAGE_OZONE_NATIVE_PIXMAP_H_
+#define UI_GL_GL_IMAGE_OZONE_NATIVE_PIXMAP_H_
+
+#include "ui/gfx/gpu_memory_buffer.h"
+#include "ui/gl/gl_image.h"
+#include "ui/ozone/public/native_pixmap.h"
+
+namespace gfx {
+
+GL_EXPORT scoped_refptr<GLImage> CreateImageForNativePixmap(

[piman, 2015/07/24 18:41:25]

There should be an "Ozone" in this name, I think.

[dshwang, 2015/07/24 19:57:20]

change to CreateImageForOzoneNativePixmap

+    scoped_refptr<ui::NativePixmap> pixmap,
+    const Size& size,
+    GpuMemoryBuffer::Format format,
+    unsigned internalformat);

[reveman, 2015/07/24 19:13:17]

If we're going to add a ui/gl/gl_image_ozone_native_pixmap.h/cc file then we
should keep this consistent with other ui/gl/gl_image_* implemenations. e.g. one
class per file and no hidden factory in the .cc file.

Alternatively, to avoid a lot of refactoring in this CL you can just inline all
this ozone GLImage code in
content/common/gpu/gpu_memory_buffer_factory_ozone_native_pixmap.cc and save the
exercise of moving the implementation to ui/gl as a follow up.

[dshwang, 2015/07/24 19:57:20]

ui/ozone/demo and content/common/gpu/media needs this also. Both should not
depend on content/common/gpu
I think factory is practical solution in our situation. WDYT?

+
+}  // namespace gfx
+
+#endif  // UI_GL_GL_IMAGE_OZONE_NATIVE_PIXMAP_H_