ui/gl/gl_image_ozone_native_pixmap.h - Issue 1258713002: ozone: unify GpuMemoryBufferFactoryOzoneNativePixmap in content/

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/gl/gl_image_ozone_native_pixmap.h

Issue 1258713002: ozone: unify GpuMemoryBufferFactoryOzoneNativePixmap in content/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef UI_GL_GL_IMAGE_OZONE_NATIVE_PIXMAP_H_

	6 #define UI_GL_GL_IMAGE_OZONE_NATIVE_PIXMAP_H_

	7

	8 #include "ui/gfx/gpu_memory_buffer.h"

	9 #include "ui/gl/gl_image.h"

	10 #include "ui/ozone/public/native_pixmap.h"

	11

	12 namespace gfx {

	13

	14 GL_EXPORT scoped_refptr<GLImage> CreateImageForNativePixmap(
	piman 2015/07/24 18:41:25 There should be an "Ozone" in this name, I think. There should be an "Ozone" in this name, I think. dshwang 2015/07/24 19:57:20 change to CreateImageForOzoneNativePixmap Show quoted text On 2015/07/24 18:41:25, piman (Very slow to review) wrote: > There should be an "Ozone" in this name, I think. change to CreateImageForOzoneNativePixmap
	15 scoped_refptr<ui::NativePixmap> pixmap,

	16 const Size& size,

	17 GpuMemoryBuffer::Format format,

	18 unsigned internalformat);
	reveman 2015/07/24 19:13:17 If we're going to add a ui/gl/gl_image_ozone_nativ If we're going to add a ui/gl/gl_image_ozone_native_pixmap.h/cc file then we should keep this consistent with other ui/gl/gl_image_* implemenations. e.g. one class per file and no hidden factory in the .cc file. Alternatively, to avoid a lot of refactoring in this CL you can just inline all this ozone GLImage code in content/common/gpu/gpu_memory_buffer_factory_ozone_native_pixmap.cc and save the exercise of moving the implementation to ui/gl as a follow up. dshwang 2015/07/24 19:57:20 ui/ozone/demo and content/common/gpu/media needs t Show quoted text On 2015/07/24 19:13:17, reveman wrote: > If we're going to add a ui/gl/gl_image_ozone_native_pixmap.h/cc file then we > should keep this consistent with other ui/gl/gl_image_* implemenations. e.g. one > class per file and no hidden factory in the .cc file. > > Alternatively, to avoid a lot of refactoring in this CL you can just inline all > this ozone GLImage code in > content/common/gpu/gpu_memory_buffer_factory_ozone_native_pixmap.cc and save the > exercise of moving the implementation to ui/gl as a follow up. ui/ozone/demo and content/common/gpu/media needs this also. Both should not depend on content/common/gpu I think factory is practical solution in our situation. WDYT?
	19

	20 } // namespace gfx

	21

	22 #endif // UI_GL_GL_IMAGE_OZONE_NATIVE_PIXMAP_H_

OLD	NEW

« content/common/gpu/gpu_memory_buffer_factory_ozone_native_pixmap.cc ('K') | « ui/gl/gl.gyp ('k') | ui/gl/gl_image_ozone_native_pixmap.cc » ('j') | ui/gl/gl_image_ozone_native_pixmap.cc » ('J')