cipd: Make it work on Windows.

cipd: Make it work on Windows.

1. Fixing all existing tests to not use symlinks on Windows.
2. Add some win-specific tests.
3. Use _current.txt regular file instead of _current symlink in .cipd/*.

Use case of replacing locked file (e.g. running executable) hasn't been
tested yet (probably doesn't work, will be done in a followup).

R=nodir@chromium.org
BUG=481661
Committed: https://chromium.googlesource.com/infra/infra/+/b932bf12d627ad22db110027f024110ffae07237

[Vadim Sh., 2015-07-28 01:20:18]

PTAL

Mostly tests.

https://codereview.chromium.org/1258673004/diff/1/go/src/infra/tools/cipd/loc...
File go/src/infra/tools/cipd/local/deployer_test.go (right):

https://codereview.chromium.org/1258673004/diff/1/go/src/infra/tools/cipd/loc...
go/src/infra/tools/cipd/local/deployer_test.go:406: func
TestDeployInstanceCopyModeWindows(t *testing.T) {
copy pasta from TestDeployInstanceCopyModePosix adjusted to Windows

https://codereview.chromium.org/1258673004/diff/1/go/src/infra/tools/cipd/loc...
File go/src/infra/tools/cipd/local/files_test.go (right):

https://codereview.chromium.org/1258673004/diff/1/go/src/infra/tools/cipd/loc...
go/src/infra/tools/cipd/local/files_test.go:195: Convey("WrapFile executable
file works", func() {
rietveld is confused. No code changes here. Groups posix-specific tests together
under one 'if'.

https://codereview.chromium.org/1258673004/diff/1/go/src/infra/tools/cipd/loc...
File go/src/infra/tools/cipd/local/fs.go (right):

https://codereview.chromium.org/1258673004/diff/1/go/src/infra/tools/cipd/loc...
go/src/infra/tools/cipd/local/fs.go:191: // the nuclear version (e.g replacing a
non-empty directory).
it's a prep work for "replace locked files". The corresponding code will be
concentrated in Replace(...).

[nodir, 2015-07-29 20:43:47]

lgtm

https://codereview.chromium.org/1258673004/diff/1/go/src/infra/tools/cipd/loc...
File go/src/infra/tools/cipd/local/deployer.go (right):

https://codereview.chromium.org/1258673004/diff/1/go/src/infra/tools/cipd/loc...
go/src/infra/tools/cipd/local/deployer.go:337: if runtime.GOOS == "windows" {
If you have more GOOS branching, consider splitting deployerImpl to unixDeployer
and winDeployer

https://codereview.chromium.org/1258673004/diff/1/go/src/infra/tools/cipd/loc...
File go/src/infra/tools/cipd/local/fs.go (right):

https://codereview.chromium.org/1258673004/diff/1/go/src/infra/tools/cipd/loc...
go/src/infra/tools/cipd/local/fs.go:139: // TODO(vadimsh): Do not fail if path
already exists and is a regular file?
probably not, because this func must ensure that a directory at that path exists

[Vadim Sh., 2015-07-29 21:04:28]

https://codereview.chromium.org/1258673004/diff/1/go/src/infra/tools/cipd/loc...
File go/src/infra/tools/cipd/local/deployer.go (right):

https://codereview.chromium.org/1258673004/diff/1/go/src/infra/tools/cipd/loc...
go/src/infra/tools/cipd/local/deployer.go:337: if runtime.GOOS == "windows" {
On 2015/07/29 20:43:47, nodir wrote:
> If you have more GOOS branching, consider splitting deployerImpl to
unixDeployer
> and winDeployer

Acknowledged. I don't think I'll have more. I specifically extracted
getCurrentInstanceID and setCurrentInstanceID into separate functions to
concentrate GOOS branching here.

https://codereview.chromium.org/1258673004/diff/1/go/src/infra/tools/cipd/loc...
File go/src/infra/tools/cipd/local/fs.go (right):

https://codereview.chromium.org/1258673004/diff/1/go/src/infra/tools/cipd/loc...
go/src/infra/tools/cipd/local/fs.go:139: // TODO(vadimsh): Do not fail if path
already exists and is a regular file?
On 2015/07/29 20:43:47, nodir wrote:
> probably not, because this func must ensure that a directory at that path
exists

I mean if a/b/c exists and is a regular file, EnsureDirectory("a/b/c") currently
will fail. This TODO is to make it work. Though I'm not sure it's needed, thus
"?".

[Vadim Sh., 2015-07-29 21:04:36]

The CQ bit was checked by vadimsh@chromium.org

[commit-bot: I haz the power, 2015-07-29 21:04:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1258673004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1258673004/1

[commit-bot: I haz the power, 2015-07-29 21:07:47]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/infra/infra/+/b932bf12d627ad22db110027f0241...

[nodir, 2015-07-29 21:08:59]

https://codereview.chromium.org/1258673004/diff/1/go/src/infra/tools/cipd/loc...
File go/src/infra/tools/cipd/local/fs.go (right):

https://codereview.chromium.org/1258673004/diff/1/go/src/infra/tools/cipd/loc...
go/src/infra/tools/cipd/local/fs.go:139: // TODO(vadimsh): Do not fail if path
already exists and is a regular file?
On 2015/07/29 21:04:28, Vadim Sh. wrote:
> On 2015/07/29 20:43:47, nodir wrote:
> > probably not, because this func must ensure that a directory at that path
> exists
> 
> I mean if a/b/c exists and is a regular file, EnsureDirectory("a/b/c")
currently
> will fail. This TODO is to make it work. Though I'm not sure it's needed, thus
> "?".

Acknowledged.