Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: go/src/infra/tools/cipd/local/rename_posix.go

Issue 1258673004: cipd: Make it work on Windows. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« go/src/infra/tools/cipd/local/fs.go ('K') | « go/src/infra/tools/cipd/local/pkgdef_test.go ('k') | go/src/infra/tools/cipd/local/rename_windows.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: go/src/infra/tools/cipd/local/rename_posix.go
diff --git a/go/src/infra/gae/epservice/epservice_other.go b/go/src/infra/tools/cipd/local/rename_posix.go
similarity index 65%
copy from go/src/infra/gae/epservice/epservice_other.go
copy to go/src/infra/tools/cipd/local/rename_posix.go
index a60db74ffa5bb27818a69bd61bd4774c90b8b33a..8c79dcd743cf1367bc81a8a52aeef04ce23a8953 100644
--- a/go/src/infra/gae/epservice/epservice_other.go
+++ b/go/src/infra/tools/cipd/local/rename_posix.go
@@ -4,10 +4,12 @@
// +build !windows
-package main
+package local
import (
- "syscall"
+ "os"
)
-var serverStartParams = &syscall.SysProcAttr{Setpgid: true}
+func atomicRename(source, target string) error {
+ return os.Rename(source, target)
+}
« go/src/infra/tools/cipd/local/fs.go ('K') | « go/src/infra/tools/cipd/local/pkgdef_test.go ('k') | go/src/infra/tools/cipd/local/rename_windows.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698