Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 1258653002: components: Make user_prefs a source_set. (Closed)

Created:
5 years, 5 months ago by tfarina
Modified:
5 years, 5 months ago
Reviewers:
brettw, dcheng
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

components: Make user_prefs a source_set. This is a tiny component, it does not need to be a shared libray in the component build. BUG=None R=brettw@chromium.org Committed: https://crrev.com/f8a72db8313967a512ea94c05b3951c255a4b796 Cr-Commit-Position: refs/heads/master@{#340349}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -41 lines) Patch
M components/user_prefs.gypi View 2 chunks +1 line, -5 lines 0 comments Download
M components/user_prefs/BUILD.gn View 1 chunk +1 line, -4 lines 0 comments Download
M components/user_prefs/user_prefs.h View 2 chunks +2 lines, -3 lines 0 comments Download
D components/user_prefs/user_prefs_export.h View 1 chunk +0 lines, -29 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
tfarina
5 years, 5 months ago (2015-07-24 16:09:33 UTC) #1
brettw
LGTM
5 years, 5 months ago (2015-07-24 19:03:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1258653002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1258653002/1
5 years, 5 months ago (2015-07-24 20:14:21 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-24 22:09:33 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f8a72db8313967a512ea94c05b3951c255a4b796 Cr-Commit-Position: refs/heads/master@{#340349}
5 years, 5 months ago (2015-07-24 22:10:00 UTC) #6
dcheng
This appears to have blown up the tree, e.g. https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/4967 For example: AccountChooserModelTest.RespectsUserChoice (run #1): ...
5 years, 5 months ago (2015-07-25 05:21:48 UTC) #8
dcheng
5 years, 5 months ago (2015-07-25 05:22:27 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1254123002/ by dcheng@chromium.org.

The reason for reverting is: Try to fix UserPrefs::Get() crashes..

Powered by Google App Engine
This is Rietveld 408576698