Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2164)

Unified Diff: components/user_prefs.gypi

Issue 1258653002: components: Make user_prefs a source_set. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/user_prefs/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/user_prefs.gypi
diff --git a/components/user_prefs.gypi b/components/user_prefs.gypi
index 3554d0d9ae925ae079508fe9dbea4d61d0bf6a96..53b08b428efcadd7ddc25c307fd6c026865b7df0 100644
--- a/components/user_prefs.gypi
+++ b/components/user_prefs.gypi
@@ -6,7 +6,7 @@
'targets': [
{
'target_name': 'user_prefs',
- 'type': '<(component)',
+ 'type': 'static_library',
'dependencies': [
'../base/base.gyp:base',
'../base/base.gyp:base_prefs',
@@ -14,13 +14,9 @@
'include_dirs': [
'..',
],
- 'defines': [
- 'USER_PREFS_IMPLEMENTATION',
- ],
'sources': [
'user_prefs/user_prefs.cc',
'user_prefs/user_prefs.h',
- 'user_prefs/user_prefs_export.h',
],
},
],
« no previous file with comments | « no previous file | components/user_prefs/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698