Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 12586010: DevTools: extract ADB command classes, change objects' lifetimes (Closed)

Created:
7 years, 9 months ago by pfeldman
Modified:
7 years, 9 months ago
Reviewers:
vsevik
CC:
chromium-reviews, vsevik, yurys, arv+watch_chromium.org
Visibility:
Public.

Description

DevTools: extract ADB command classes, change objects' lifetimes TBR=jhawkins (for minor webui changes) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190564

Patch Set 1 #

Patch Set 2 : Win build fixed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+503 lines, -403 lines) Patch
M chrome/browser/devtools/adb_client_socket.h View 1 chunk +27 lines, -2 lines 0 comments Download
M chrome/browser/devtools/adb_client_socket.cc View 5 chunks +124 lines, -133 lines 0 comments Download
M chrome/browser/devtools/devtools_adb_bridge.h View 1 2 chunks +43 lines, -56 lines 0 comments Download
M chrome/browser/devtools/devtools_adb_bridge.cc View 2 chunks +253 lines, -186 lines 0 comments Download
M chrome/browser/resources/inspect/inspect.js View 5 chunks +10 lines, -11 lines 0 comments Download
M chrome/browser/ui/webui/inspect_ui.h View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/inspect_ui.cc View 8 chunks +41 lines, -13 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
pfeldman
7 years, 9 months ago (2013-03-25 15:31:26 UTC) #1
vsevik
lgtm
7 years, 9 months ago (2013-03-25 16:18:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pfeldman@chromium.org/12586010/1
7 years, 9 months ago (2013-03-25 17:07:48 UTC) #3
commit-bot: I haz the power
Presubmit check for 12586010-1 failed and returned exit status 1. INFO:root:Found 7 file(s). Running presubmit ...
7 years, 9 months ago (2013-03-25 17:07:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pfeldman@chromium.org/12586010/1
7 years, 9 months ago (2013-03-25 17:17:22 UTC) #5
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 9 months ago (2013-03-25 18:29:03 UTC) #6
pfeldman
7 years, 9 months ago (2013-03-26 06:20:14 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 manually as r190564 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698