Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Unified Diff: chrome/browser/ui/webui/inspect_ui.h

Issue 12586010: DevTools: extract ADB command classes, change objects' lifetimes (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Win build fixed. Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/inspect/inspect.js ('k') | chrome/browser/ui/webui/inspect_ui.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/inspect_ui.h
diff --git a/chrome/browser/ui/webui/inspect_ui.h b/chrome/browser/ui/webui/inspect_ui.h
index ec382ba77cf9bf2d8986fc4efc191c967176f66f..264b9fd4122abac6f13e15a17774a727e3f181da 100644
--- a/chrome/browser/ui/webui/inspect_ui.h
+++ b/chrome/browser/ui/webui/inspect_ui.h
@@ -44,7 +44,7 @@ class InspectUI : public content::WebUIController,
const std::string& path,
const content::WebUIDataSource::GotDataCallback& callback);
- bool HandleAdbDevicesCallback(
+ bool HandleAdbPagesCallback(
const std::string& path,
const content::WebUIDataSource::GotDataCallback& callback);
@@ -61,13 +61,16 @@ class InspectUI : public content::WebUIController,
int result,
const std::string& response);
+ void OnAdbPages(const content::WebUIDataSource::GotDataCallback& callback,
+ int result,
+ DevToolsAdbBridge::RemotePages* pages);
scoped_refptr<WorkerCreationDestructionListener> observer_;
// A scoped container for notification registries.
content::NotificationRegistrar registrar_;
- DevToolsAdbBridge* adb_bridge_;
+ scoped_ptr<DevToolsAdbBridge> adb_bridge_;
base::WeakPtrFactory<InspectUI> weak_factory_;
DISALLOW_COPY_AND_ASSIGN(InspectUI);
« no previous file with comments | « chrome/browser/resources/inspect/inspect.js ('k') | chrome/browser/ui/webui/inspect_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698