chrome/renderer/autofill/password_autofill_agent_browsertest.cc - Issue 1258593002: Reland "Add ExecuteJavaScriptForTest and make all tests use it"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/autofill/password_autofill_agent_browsertest.cc

Issue 1258593002: Reland "Add ExecuteJavaScriptForTest and make all tests use it" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/autofill/page_click_tracker_browsertest.cc ('k') | chrome/renderer/autofill/password_generation_agent_browsertest.cc » ('j') | content/browser/frame_host/render_frame_host_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/autofill/password_autofill_agent_browsertest.cc

diff --git a/chrome/renderer/autofill/password_autofill_agent_browsertest.cc b/chrome/renderer/autofill/password_autofill_agent_browsertest.cc

index cfa15cde9796fe617d9ffa1a788ce883c7419974..6a0cc2eac83a6955ad64398c8c98449702bed5e6 100644

--- a/chrome/renderer/autofill/password_autofill_agent_browsertest.cc

+++ b/chrome/renderer/autofill/password_autofill_agent_browsertest.cc

@@ -805,7 +805,7 @@ TEST_F(PasswordAutofillAgentTest, NoDOMActivationTest) {

// Trigger the initial autocomplete.

SimulateOnFillPasswordForm(fill_data_);

- ExecuteJavaScript(kJavaScriptClick);

+ ExecuteJavaScriptForTests(kJavaScriptClick);

CheckTextFieldsDOMState(kAliceUsername, true, "", true);

}

@@ -1680,7 +1680,7 @@ TEST_F(PasswordAutofillAgentTest, FindingFieldsWithAutofillPredictions) {

"new_input.setAttribute('type', 'text');"

"new_input.setAttribute('id', 'other_field');"

"form.appendChild(new_input);";

- ExecuteJavaScript(add_field_to_form.c_str());

+ ExecuteJavaScriptForTests(add_field_to_form.c_str());

static_cast<content::RenderFrameObserver*>(password_autofill_agent_)

->WillSendSubmitEvent(username_element_.form());