chrome/renderer/autofill/page_click_tracker_browsertest.cc - Issue 1258593002: Reland "Add ExecuteJavaScriptForTest and make all tests use it"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/autofill/page_click_tracker_browsertest.cc

Issue 1258593002: Reland "Add ExecuteJavaScriptForTest and make all tests use it" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/autofill/form_autofill_browsertest.cc ('k') | chrome/renderer/autofill/password_autofill_agent_browsertest.cc » ('j') | content/browser/frame_host/render_frame_host_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/autofill/page_click_tracker_browsertest.cc

diff --git a/chrome/renderer/autofill/page_click_tracker_browsertest.cc b/chrome/renderer/autofill/page_click_tracker_browsertest.cc

index a6a5a2b4ea9aabb6eb59b27e2bfb24fc73efc715..9a498c9e202e0f286a83cbfd06684ef784b97202 100644

--- a/chrome/renderer/autofill/page_click_tracker_browsertest.cc

+++ b/chrome/renderer/autofill/page_click_tracker_browsertest.cc

@@ -126,7 +126,7 @@ TEST_F(PageClickTrackerTest, PageClickTrackerInputRightClicked) {

TEST_F(PageClickTrackerTest, PageClickTrackerInputFocusedAndClicked) {

// Focus the text field without a click.

- ExecuteJavaScript("document.getElementById('text_1').focus();");

+ ExecuteJavaScriptForTests("document.getElementById('text_1').focus();");

EXPECT_FALSE(test_listener_.form_control_element_clicked_called_);

test_listener_.ClearResults();

@@ -161,7 +161,7 @@ TEST_F(PageClickTrackerTest, PageClickTrackerTextAreaClicked) {

TEST_F(PageClickTrackerTest, PageClickTrackerTextAreaFocusedAndClicked) {

// Focus the textarea without a click.

- ExecuteJavaScript("document.getElementById('textarea_1').focus();");

+ ExecuteJavaScriptForTests("document.getElementById('textarea_1').focus();");

EXPECT_FALSE(test_listener_.form_control_element_clicked_called_);

test_listener_.ClearResults();