Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 1258513003: X87: [stubs] Optimize LoadGlobalViaContextStub and StoreGlobalViaContextStub. (Closed)

Created:
5 years, 5 months ago by chunyang.dai
Modified:
5 years, 5 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [stubs] Optimize LoadGlobalViaContextStub and StoreGlobalViaContextStub. port d6ee366d5c5aef7c6bc550889a33520058b4e33a (r29834). original commit message: This is the initial round of optimizations for the LoadGlobalViaContextStub and StoreGlobalViaContextStub, basically turning them into platform code stubs to avoid the Crankshaft overhead in the fast case, and making the runtime interface cheaper. BUG= Committed: https://crrev.com/4c6989914e1a2f92d009bd78a40febd318a2e5c2 Cr-Commit-Position: refs/heads/master@{#29839}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+220 lines, -40 lines) Patch
M src/x87/code-stubs-x87.cc View 1 chunk +155 lines, -0 lines 0 comments Download
M src/x87/full-codegen-x87.cc View 2 chunks +29 lines, -19 lines 0 comments Download
M src/x87/interface-descriptors-x87.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/x87/lithium-codegen-x87.cc View 2 chunks +31 lines, -19 lines 0 comments Download
M src/x87/macro-assembler-x87.h View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL
5 years, 5 months ago (2015-07-24 09:29:01 UTC) #2
Weiliang
lgtm
5 years, 5 months ago (2015-07-24 09:32:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1258513003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1258513003/1
5 years, 5 months ago (2015-07-24 09:32:58 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-24 10:08:50 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-24 10:09:02 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4c6989914e1a2f92d009bd78a40febd318a2e5c2
Cr-Commit-Position: refs/heads/master@{#29839}

Powered by Google App Engine
This is Rietveld 408576698