Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Unified Diff: src/x87/lithium-codegen-x87.cc

Issue 1258513003: X87: [stubs] Optimize LoadGlobalViaContextStub and StoreGlobalViaContextStub. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/x87/interface-descriptors-x87.cc ('k') | src/x87/macro-assembler-x87.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/x87/lithium-codegen-x87.cc
diff --git a/src/x87/lithium-codegen-x87.cc b/src/x87/lithium-codegen-x87.cc
index dc5f2eec7a1f0cdf1124219d165a019d87e63781..ee96cf698801e8c1c0deb3c6e53baad5459891ad 100644
--- a/src/x87/lithium-codegen-x87.cc
+++ b/src/x87/lithium-codegen-x87.cc
@@ -3150,15 +3150,19 @@ void LCodeGen::DoLoadGlobalViaContext(LLoadGlobalViaContext* instr) {
DCHECK(ToRegister(instr->context()).is(esi));
DCHECK(ToRegister(instr->result()).is(eax));
- __ mov(LoadGlobalViaContextDescriptor::DepthRegister(),
- Immediate(Smi::FromInt(instr->depth())));
- __ mov(LoadGlobalViaContextDescriptor::SlotRegister(),
- Immediate(Smi::FromInt(instr->slot_index())));
- __ mov(LoadGlobalViaContextDescriptor::NameRegister(), instr->name());
-
- Handle<Code> stub =
- CodeFactory::LoadGlobalViaContext(isolate(), instr->depth()).code();
- CallCode(stub, RelocInfo::CODE_TARGET, instr);
+ int const slot = instr->slot_index();
+ int const depth = instr->depth();
+ if (depth <= LoadGlobalViaContextStub::kMaximumDepth) {
+ __ mov(LoadGlobalViaContextDescriptor::SlotRegister(), slot);
+ __ mov(LoadGlobalViaContextDescriptor::NameRegister(), instr->name());
+ Handle<Code> stub =
+ CodeFactory::LoadGlobalViaContext(isolate(), depth).code();
+ CallCode(stub, RelocInfo::CODE_TARGET, instr);
+ } else {
+ __ Push(Smi::FromInt(slot));
+ __ Push(instr->name());
+ __ CallRuntime(Runtime::kLoadGlobalViaContext, 2);
+ }
}
@@ -4546,16 +4550,24 @@ void LCodeGen::DoStoreGlobalViaContext(LStoreGlobalViaContext* instr) {
DCHECK(ToRegister(instr->value())
.is(StoreGlobalViaContextDescriptor::ValueRegister()));
- __ mov(StoreGlobalViaContextDescriptor::DepthRegister(),
- Immediate(Smi::FromInt(instr->depth())));
- __ mov(StoreGlobalViaContextDescriptor::SlotRegister(),
- Immediate(Smi::FromInt(instr->slot_index())));
- __ mov(StoreGlobalViaContextDescriptor::NameRegister(), instr->name());
-
- Handle<Code> stub =
- CodeFactory::StoreGlobalViaContext(isolate(), instr->depth(),
- instr->language_mode()).code();
- CallCode(stub, RelocInfo::CODE_TARGET, instr);
+ int const slot = instr->slot_index();
+ int const depth = instr->depth();
+ if (depth <= StoreGlobalViaContextStub::kMaximumDepth) {
+ __ mov(StoreGlobalViaContextDescriptor::SlotRegister(), slot);
+ __ mov(StoreGlobalViaContextDescriptor::NameRegister(), instr->name());
+ Handle<Code> stub = CodeFactory::StoreGlobalViaContext(
+ isolate(), depth, instr->language_mode())
+ .code();
+ CallCode(stub, RelocInfo::CODE_TARGET, instr);
+ } else {
+ __ Push(Smi::FromInt(slot));
+ __ Push(instr->name());
+ __ Push(StoreGlobalViaContextDescriptor::ValueRegister());
+ __ CallRuntime(is_strict(instr->language_mode())
+ ? Runtime::kStoreGlobalViaContext_Strict
+ : Runtime::kStoreGlobalViaContext_Sloppy,
+ 3);
+ }
}
« no previous file with comments | « src/x87/interface-descriptors-x87.cc ('k') | src/x87/macro-assembler-x87.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698