Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1258323004: Reland #1: Clean up interface of attachment broker. (Closed)

Created:
5 years, 4 months ago by erikchen
Modified:
5 years, 4 months ago
Reviewers:
Tom Sepez
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland #1: Clean up interface of attachment broker. I forgot to initialize a member variable, which is why the original CL flakily succeeded (and managed to pass the CQ). Original issue's description: > ipc: Clean up interface of attachment broker. > > AttachmentBrokerUnprivileged now has a method > DesignateBrokerCommunicationChannel which is used by non-broker processes to > designate an IPC::Channel as the communication medium for brokerable attachment > messages. IPC::Channel has a new member attachment_broker_endpoint_ which causes > it to pass all messages through the attachment broker before forwarding them to > the listener. > > BUG=493414 > > Committed: https://crrev.com/9a06836982214f2edced21bbd1615b49e7f231bf > Cr-Commit-Position: refs/heads/master@{#341143} BUG=493414 TBR=tsepez@chromium.org Committed: https://crrev.com/8c73f834bc73178123389c29d7627e29cb09d501 Cr-Commit-Position: refs/heads/master@{#341207}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -5 lines) Patch
M ipc/attachment_broker_privileged.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ipc/attachment_broker_privileged_win_unittest.cc View 2 chunks +4 lines, -1 line 0 comments Download
M ipc/attachment_broker_unprivileged.h View 2 chunks +4 lines, -1 line 0 comments Download
M ipc/attachment_broker_unprivileged.cc View 1 chunk +12 lines, -1 line 0 comments Download
M ipc/ipc_channel.h View 2 chunks +12 lines, -0 lines 0 comments Download
M ipc/ipc_channel_nacl.h View 1 chunk +1 line, -0 lines 0 comments Download
M ipc/ipc_channel_nacl.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ipc/ipc_channel_posix.h View 1 chunk +1 line, -0 lines 0 comments Download
M ipc/ipc_channel_posix.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ipc/ipc_channel_reader.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ipc/ipc_channel_reader.cc View 1 chunk +11 lines, -2 lines 0 comments Download
M ipc/ipc_channel_reader_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ipc/ipc_channel_win.h View 1 chunk +1 line, -0 lines 0 comments Download
M ipc/ipc_channel_win.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1258323004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1258323004/1
5 years, 4 months ago (2015-07-30 21:03:18 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-07-30 22:26:19 UTC) #3
commit-bot: I haz the power
5 years, 4 months ago (2015-07-30 22:27:26 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8c73f834bc73178123389c29d7627e29cb09d501
Cr-Commit-Position: refs/heads/master@{#341207}

Powered by Google App Engine
This is Rietveld 408576698