Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Side by Side Diff: ipc/attachment_broker_privileged.cc

Issue 1258323004: Reland #1: Clean up interface of attachment broker. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | ipc/attachment_broker_privileged_win_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ipc/attachment_broker_privileged.h" 5 #include "ipc/attachment_broker_privileged.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "ipc/ipc_channel.h" 9 #include "ipc/ipc_channel.h"
10 10
11 namespace IPC { 11 namespace IPC {
12 12
13 AttachmentBrokerPrivileged::AttachmentBrokerPrivileged() {} 13 AttachmentBrokerPrivileged::AttachmentBrokerPrivileged() {}
14 14
15 AttachmentBrokerPrivileged::~AttachmentBrokerPrivileged() {} 15 AttachmentBrokerPrivileged::~AttachmentBrokerPrivileged() {}
16 16
17 void AttachmentBrokerPrivileged::RegisterCommunicationChannel( 17 void AttachmentBrokerPrivileged::RegisterCommunicationChannel(
18 Channel* channel) { 18 Channel* channel) {
19 channel->set_attachment_broker_endpoint(true);
19 auto it = std::find(channels_.begin(), channels_.end(), channel); 20 auto it = std::find(channels_.begin(), channels_.end(), channel);
20 DCHECK(channels_.end() == it); 21 DCHECK(channels_.end() == it);
21 channels_.push_back(channel); 22 channels_.push_back(channel);
22 } 23 }
23 24
24 void AttachmentBrokerPrivileged::DeregisterCommunicationChannel( 25 void AttachmentBrokerPrivileged::DeregisterCommunicationChannel(
25 Channel* channel) { 26 Channel* channel) {
26 auto it = std::find(channels_.begin(), channels_.end(), channel); 27 auto it = std::find(channels_.begin(), channels_.end(), channel);
27 if (it != channels_.end()) 28 if (it != channels_.end())
28 channels_.erase(it); 29 channels_.erase(it);
29 } 30 }
30 31
31 Channel* AttachmentBrokerPrivileged::GetChannelWithProcessId( 32 Channel* AttachmentBrokerPrivileged::GetChannelWithProcessId(
32 base::ProcessId id) { 33 base::ProcessId id) {
33 auto it = std::find_if(channels_.begin(), channels_.end(), 34 auto it = std::find_if(channels_.begin(), channels_.end(),
34 [id](Channel* c) { return c->GetPeerPID() == id; }); 35 [id](Channel* c) { return c->GetPeerPID() == id; });
35 if (it == channels_.end()) 36 if (it == channels_.end())
36 return nullptr; 37 return nullptr;
37 return *it; 38 return *it;
38 } 39 }
39 40
40 } // namespace IPC 41 } // namespace IPC
OLDNEW
« no previous file with comments | « no previous file | ipc/attachment_broker_privileged_win_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698