Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 1258313006: Make startOfParagraph() not to use Position::deprecatedEditingOffset() (Closed)

Created:
5 years, 4 months ago by yosin_UTC9
Modified:
5 years, 4 months ago
Reviewers:
tkent, yoichio, hajimehoshi
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Make startOfParagraph() not to use Position::deprecatedEditingOffset() This patch replaces |Position::deprecatedEditingOffset()| call in |startOfParagraph()| by |Position::computeEditingOffset()|, since it is used for computing offset of |VisiblePosition| which can not be middle of editing ignore content, for improving code health. This patch is a preparation of getting rid of legacy editing position. BUG=513114 TEST=n/a; no behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199887

Patch Set 1 : 2015-08-03T15:27:45 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/core/editing/VisibleUnits.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
yosin_UTC9
PTAL
5 years, 4 months ago (2015-08-03 06:47:16 UTC) #2
tkent
lgtm
5 years, 4 months ago (2015-08-03 07:08:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1258313006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1258313006/1
5 years, 4 months ago (2015-08-03 07:09:09 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-03 08:38:18 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=199887

Powered by Google App Engine
This is Rietveld 408576698