Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Unified Diff: build/config/android/rules.gni

Issue 1258303003: [Android] Suppress findbugs stderr output. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase + reenable findbugs_verbose on GN Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/android/internal_rules.gni ('k') | build/java.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/android/rules.gni
diff --git a/build/config/android/rules.gni b/build/config/android/rules.gni
index f627e43699ec53c375921868f619e07dd789f2cf..1e6a689a7baed87c584ff5642892b966de1507e6 100644
--- a/build/config/android/rules.gni
+++ b/build/config/android/rules.gni
@@ -1592,6 +1592,10 @@ template("android_apk") {
srcjar_deps = _srcjar_deps
dex_path = base_path + ".dex.jar"
+ if (defined(invoker.run_findbugs)) {
+ run_findbugs = invoker.run_findbugs
+ }
Dirk Pranke 2015/08/17 19:25:02 this can be replaced with forward_variables_from(i
jbudorick 2015/08/22 22:45:19 ack, I'll send you a follow-up CL. agrieve partial
+
if (defined(invoker.deps)) {
deps += invoker.deps
}
@@ -1908,6 +1912,7 @@ template("instrumentation_test_apk") {
if (defined(invoker.DEPRECATED_java_in_dir)) {
DEPRECATED_java_in_dir = invoker.DEPRECATED_java_in_dir
}
+ run_findbugs = false
}
}
« no previous file with comments | « build/config/android/internal_rules.gni ('k') | build/java.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698