Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Unified Diff: build/config/android/internal_rules.gni

Issue 1258303003: [Android] Suppress findbugs stderr output. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase + reenable findbugs_verbose on GN Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/config/android/internal_rules.gni
diff --git a/build/config/android/internal_rules.gni b/build/config/android/internal_rules.gni
index c777cf55c73511d903f1622b167e912989606b83..afd988d792cf47b3146de9ebe2a19231e7224067 100644
--- a/build/config/android/internal_rules.gni
+++ b/build/config/android/internal_rules.gni
@@ -116,6 +116,10 @@ template("findbugs") {
rebase_path(result_path, root_build_dir),
rebase_path(jar_path, root_build_dir),
]
+
+ if (findbugs_verbose) {
+ args += [ "-vv" ]
+ }
}
}
@@ -1259,12 +1263,17 @@ template("java_library_impl") {
}
}
+ if (defined(invoker.run_findbugs)) {
+ run_findbugs = invoker.run_findbugs
+ }
if (run_findbugs) {
_final_datadeps += [ ":${_template_name}__findbugs" ]
findbugs("${_template_name}__findbugs") {
build_config = _build_config
jar_path = _jar_path
- deps = build_config_deps
+ deps = [
+ ":$_compile_java_target",
+ ]
}
}
}

Powered by Google App Engine
This is Rietveld 408576698