Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: build/android/pylib/utils/findbugs.py

Issue 1258303003: [Android] Suppress findbugs stderr output. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/pylib/cmd_helper.py ('k') | build/config/android/config.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/pylib/utils/findbugs.py
diff --git a/build/android/pylib/utils/findbugs.py b/build/android/pylib/utils/findbugs.py
index 8deb0fe274de99773ccb53be24e720fb2ba9251c..6ad856f5306aea71a08dd20a28d600b9a51573e1 100644
--- a/build/android/pylib/utils/findbugs.py
+++ b/build/android/pylib/utils/findbugs.py
@@ -142,12 +142,16 @@ def Run(exclude, classes_to_analyze, auxiliary_classes, output_file,
cmd.extend(os.path.abspath(j) for j in jars or [])
if output_file:
- cmd_helper.RunCmd(cmd)
+ _, _, stderr = cmd_helper.GetCmdStatusOutputAndError(cmd)
+
results_doc = xml.dom.minidom.parse(output_file)
else:
- raw_out = cmd_helper.GetCmdOutput(cmd)
+ _, raw_out, stderr = cmd_helper.GetCmdStatusOutputAndError(cmd)
results_doc = xml.dom.minidom.parseString(raw_out)
+ for line in stderr.splitlines():
+ logging.debug(' %s', line)
+
current_warnings_set = _ParseXmlResults(results_doc)
return (' '.join(cmd), current_warnings_set)
« no previous file with comments | « build/android/pylib/cmd_helper.py ('k') | build/config/android/config.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698