Issue 12583002: REGRESSION(r174613) Bookmark manager: Ctrl+C, Ctrl+X, and Ctrl+V doesn't work

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12583002: REGRESSION(r174613) Bookmark manager: Ctrl+C, Ctrl+X, and Ctrl+V doesn't work (Closed)

Created:
7 years, 9 months ago by yosin_UTC9

Modified:
7 years, 9 months ago

Reviewers:
arv (Not doing code reviews)

CC:
chromium-reviews, arv+watch_chromium.org, yoichio

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

REGRESSION(r174613) Bookmark manager: Ctrl+C, Ctrl+X, and Ctrl+V doesn't work This patch fixes regerssion of r174613. Conditional expression for checking active element was wrong, it uses "||" rather than "&&" Bad patch: https://codereview.chromium.org/12387036/ BUG=174613 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186843

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/resources/bookmark_manager/js/main.js	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

yosin_UTC9

Hi Eric, Could you review this patch? This is another patch for fixing Ctrl+{C,X,V} issue. ...

7 years, 9 months ago (2013-03-07 05:50:50 UTC) #1

yosin_UTC9

7 years, 9 months ago (2013-03-08 01:48:33 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r186843 (presubmit successful).