Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Issue 12387036: Bookmark manager: Handle "copy", "cut"and "paste" events only when list or tree pane active. (Closed)

Created:
7 years, 9 months ago by yosin_UTC9
Modified:
7 years, 9 months ago
CC:
chromium-reviews, arv+watch_chromium.org, yoichio, kenjibaheux
Visibility:
Public.

Description

Bookmark manager: Handle "copy", "cut"and "paste" events only when list or tree pane active. This caused by a change of getSelectedBookmarkNodes() in r172230. Before r177230, getSelectedBookmarkNodes() threw error unless list or tree is active. From r177230, getSelectedBookmarkNodes() returns selected items of list when list nor tree is active. Note: For a11y, when context menu or organize menu is open, menu takes focus. So, list/tree is no more active element when menu is opened. This causes "cut" event handler of document object does "cut" operation on an active item of list. In bug case, an active item is editing bookmark. This patch changes to check active element in "copy", "cut", and "paste" event handler. BUG=174613 TEST=On bookmark manager, edit/rename bookmark/folder and hit Ctrl+X in edit field. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186312

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/resources/bookmark_manager/js/main.js View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
yosin_UTC9
Hi Eric, Could you review this patch? Thanks in advance. Note: we also need to ...
7 years, 9 months ago (2013-03-01 04:30:46 UTC) #1
yosin_UTC9
ping
7 years, 9 months ago (2013-03-04 02:20:56 UTC) #2
arv (Not doing code reviews)
LGTM
7 years, 9 months ago (2013-03-05 18:59:32 UTC) #3
yosin_UTC9
7 years, 9 months ago (2013-03-06 01:18:02 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r186312 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698