Issue 1258293004: Revert "Move the rest of src headers used by include to include/private."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1258293004: Revert "Move the rest of src headers used by include to include/private." (Closed)

Created:
5 years, 4 months ago by mtklein_C

Modified:
5 years, 4 months ago

Reviewers:

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Revert "Move the rest of src headers used by include to include/private." This reverts commit d12e6ffa5cc1c1af47bf73c7c127d8d7f7443058. Our Chrome roll canaries are failing with the dreaded Ninja-says-there's-more-work-to-do message. I will break this up smaller (if possible) and try again tomorrow. BUG=skia:4126 Committed: https://skia.googlesource.com/skia/+/3a4b13498885dc42970b9795c0cc3d71fcb8b810

Patch Set 1 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+-1 lines, -627 lines)			Patch
M	include/core/SkPictureRecorder.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	include/gpu/gl/SkGLContext.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
D	include/private/SkFunction.h	View	1 chunk	+0 lines, -75 lines	0 comments	Download
D	include/private/SkGpuFenceSync.h	View	1 chunk	+0 lines, -29 lines	0 comments	Download
D	include/private/SkMiniRecorder.h	View	1 chunk	+0 lines, -60 lines	0 comments	Download
D	include/private/SkPathPriv.h	View	1 chunk	+0 lines, -64 lines	0 comments	Download
D	include/private/SkRecords.h	View	1 chunk	+0 lines, -400 lines	0 comments	Download
M	include/views/SkOSWindow_Win.h	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	src/core/SkFunction.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	src/core/SkMiniRecorder.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	src/core/SkPathPriv.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	src/core/SkRecords.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	src/gpu/SkGpuFenceSync.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

mtklein_C

5 years, 4 months ago (2015-07-28 20:01:26 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
3a4b13498885dc42970b9795c0cc3d71fcb8b810 (presubmit successful).

Expand Messages | Collapse Messages