Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Issue 1258283004: Merge to XFA: Name IFX_SysFontInfo subclasses consistently. (Closed)

Created:
5 years, 4 months ago by Tom Sepez
Modified:
5 years, 4 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: Name IFX_SysFontInfo subclasses consistently. (cherry picked from commit 4d2e494e38ffdeb0143fbe3f624743499ebcac80) Original Review URL: https://codereview.chromium.org/1257743005 . R=thestig@chromium.org TBR=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/58b2a2cef3f50c8cc771708798214c7a785fdad0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -27 lines) Patch
M core/src/fxge/win32/fx_win32_device.cpp View 13 chunks +20 lines, -20 lines 0 comments Download
M fpdfsdk/src/fpdf_sysfontinfo.cpp View 3 chunks +9 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Tom Sepez
TBR, nearly automatic (new / FX_NEW hangups).
5 years, 4 months ago (2015-07-31 21:25:37 UTC) #1
Lei Zhang
lgtm
5 years, 4 months ago (2015-07-31 21:26:33 UTC) #2
Tom Sepez
5 years, 4 months ago (2015-07-31 21:39:25 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
58b2a2cef3f50c8cc771708798214c7a785fdad0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698