Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 1257743005: Name IFX_SysFontInfo subclasses consistently. (Closed)

Created:
5 years, 4 months ago by Tom Sepez
Modified:
5 years, 4 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Name IFX_SysFontInfo subclasses consistently. Nearly a naming-only change, but add one argument to constructor. grep now shows: class CFX_AndroidFontInfo : public IFX_SystemFontInfo class CFX_Win32FontInfo final : public IFX_SystemFontInfo class CFX_ExternalFontInfo final : public IFX_SystemFontInfo class CFX_FolderFontInfo : public IFX_SystemFontInfo class CFX_MacFontInfo : public CFX_FolderFontInfo class CFX_LinuxFontInfo : public CFX_FolderFontInfo R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/4d2e494e38ffdeb0143fbe3f624743499ebcac80

Patch Set 1 #

Patch Set 2 : whitespace #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -27 lines) Patch
M core/src/fxge/win32/fx_win32_device.cpp View 13 chunks +20 lines, -20 lines 0 comments Download
M fpdfsdk/src/fpdf_sysfontinfo.cpp View 1 3 chunks +9 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Tom Sepez
Lei, for review.
5 years, 4 months ago (2015-07-31 20:53:20 UTC) #2
Lei Zhang
lgtm typos: "subclassess" "consistenly"
5 years, 4 months ago (2015-07-31 21:05:24 UTC) #3
Tom Sepez
5 years, 4 months ago (2015-07-31 21:21:45 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
4d2e494e38ffdeb0143fbe3f624743499ebcac80 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698