Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 1258173002: Changing command line flag from disable appcontainer to enable appcontainer. (Closed)

Created:
5 years, 4 months ago by Shrikant Kelkar
Modified:
5 years, 4 months ago
Reviewers:
jschuh, nasko, Will Harris
CC:
chromium-reviews, darin-cc_chromium.org, jam, rickyz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Changing command line flag from disable appcontainer to enable appcontainer. As there are some reports on stable channel which suggest that CreateProcess is randomly failing when used with lowbox token, changing disable appcontainer flag to enable if required. BUG=467920 R=jschuh@chromium.org,wfh@chromium.org Committed: https://crrev.com/354d94497b96ffa913a7c5d562d2d88d658b9401 Cr-Commit-Position: refs/heads/master@{#340815}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M content/common/sandbox_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/common/content_switches.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (2 generated)
Shrikant Kelkar
5 years, 4 months ago (2015-07-28 01:33:30 UTC) #1
Will Harris
I think we should aim to get actionable data here. I suggest putting this behind ...
5 years, 4 months ago (2015-07-28 03:04:30 UTC) #2
Will Harris
I looked through the stability data for bug 467920 and can't find any correlation here ...
5 years, 4 months ago (2015-07-28 03:22:36 UTC) #3
Shrikant Kelkar
On 2015/07/28 03:22:36, Will Harris wrote: > I looked through the stability data for bug ...
5 years, 4 months ago (2015-07-28 03:36:57 UTC) #4
Shrikant Kelkar
On 2015/07/28 03:36:57, Shrikant Kelkar wrote: > On 2015/07/28 03:22:36, Will Harris wrote: > > ...
5 years, 4 months ago (2015-07-28 19:57:36 UTC) #5
Will Harris
lgtm for sandbox_win.cc - probably need a content/ owner for the rest.
5 years, 4 months ago (2015-07-28 20:21:25 UTC) #6
Will Harris
+nasko
5 years, 4 months ago (2015-07-28 20:31:31 UTC) #8
nasko
LGTM
5 years, 4 months ago (2015-07-28 22:33:27 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1258173002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1258173002/1
5 years, 4 months ago (2015-07-28 22:51:27 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-07-28 23:57:15 UTC) #12
commit-bot: I haz the power
5 years, 4 months ago (2015-07-28 23:57:58 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/354d94497b96ffa913a7c5d562d2d88d658b9401
Cr-Commit-Position: refs/heads/master@{#340815}

Powered by Google App Engine
This is Rietveld 408576698