android/apps: Add CanvasProof App;

android/apps: Add CanvasProof App;

Compare Ganesh and HWUI canvas rendering of SKPs on android.

Put SKP files in .../canvasproof/src/main/assets/skps

Run on a Marshmallow device.

NOTREECHECKS=true

Committed: https://skia.googlesource.com/skia/+/ab26a9b427ec7c525ccd0025f19f0c91b74d8f6d

[hal.canary, 2015-07-28 21:31:41]

Just uploading the current state of the project, for posterity.  Take a look if
you like.

[hal.canary, 2015-07-28 21:33:22]

Patchset #2 (id:20001) has been deleted

[hal.canary, 2015-07-28 21:33:29]

Patchset #1 (id:1) has been deleted

[hal.canary, 2015-08-21 17:08:45]

halcanary@google.com changed reviewers:
+ djsollen@google.com, tomhudson@google.com

[hal.canary, 2015-08-21 17:09:35]

PTAL

[tomhudson, 2015-08-22 19:15:52]

Half-review:

https://codereview.chromium.org/1258123004/diff/140001/.gitignore
File .gitignore (right):

https://codereview.chromium.org/1258123004/diff/140001/.gitignore#newcode27
.gitignore:27: /tools/skp/page_sets/data/*.wpr
Why add leading slashes, particularly to some but not all? This is not what I'd
expect with a unix filesystem.

https://codereview.chromium.org/1258123004/diff/140001/platform_tools/android...
File platform_tools/android/apps/canvasproof/build.gradle (right):

https://codereview.chromium.org/1258123004/diff/140001/platform_tools/android...
platform_tools/android/apps/canvasproof/build.gradle:10: buildToolsVersion
"22.0.1"
Nit: this is significantly newer than necessary for SDK 19, if I'm reading
https://developer.android.com/tools/revisions/build-tools.html right.

https://codereview.chromium.org/1258123004/diff/140001/platform_tools/android...
platform_tools/android/apps/canvasproof/build.gradle:19:
sourceSets.main.jniLibs.srcDir "src/main/libs"
Doesn't this need = ?

https://codereview.chromium.org/1258123004/diff/140001/platform_tools/android...
File
platform_tools/android/apps/canvasproof/src/main/java/org/skia/canvasproof/CanvasProofActivity.java
(right):

https://codereview.chromium.org/1258123004/diff/140001/platform_tools/android...
platform_tools/android/apps/canvasproof/src/main/java/org/skia/canvasproof/CanvasProofActivity.java:37:
@SuppressWarnings("deprecation")  // purposely using this
Nit: given that we're using a deprecated feature, I'd appreciate the comment
saying *why*; this comment doesn't tell me much.

https://codereview.chromium.org/1258123004/diff/140001/platform_tools/android...
platform_tools/android/apps/canvasproof/src/main/java/org/skia/canvasproof/CanvasProofActivity.java:59:
Log.e(TAG, "IOException in getAssetPaths", e);
Can you more explicitly list what failed here? Not knowing where to install
assets is a common failure mode, and good error messages are a backstop to good
documentation.

https://codereview.chromium.org/1258123004/diff/140001/platform_tools/android...
platform_tools/android/apps/canvasproof/src/main/java/org/skia/canvasproof/CanvasProofActivity.java:63:
Log.e(TAG, "this.getAssets().getAssetPaths returned null");
How about "found no resources in path <directory>"?
Isn't a non-null but 0-length resources also something we should be erroring on?

https://codereview.chromium.org/1258123004/diff/140001/platform_tools/android...
platform_tools/android/apps/canvasproof/src/main/java/org/skia/canvasproof/CanvasProofActivity.java:71:
Log.v(TAG, "loading " + path);
If we don't need these logs any more, please strip them out before committing -
Android logspam is nasty tragedy of the commons.

https://codereview.chromium.org/1258123004/diff/140001/platform_tools/android...
platform_tools/android/apps/canvasproof/src/main/java/org/skia/canvasproof/CanvasProofActivity.java:149:
this.hwuiPictureView
If HwuiPictureView extends View, why have another anonymous view here wrapping
it instead of just setting its layout params and adding it directly?

[djsollen, 2015-08-24 12:42:56]

https://codereview.chromium.org/1258123004/diff/140001/.gitignore
File .gitignore (right):

https://codereview.chromium.org/1258123004/diff/140001/.gitignore#newcode27
.gitignore:27: /tools/skp/page_sets/data/*.wpr
On 2015/08/22 19:15:51, tomhudson wrote:
> Why add leading slashes, particularly to some but not all? This is not what
I'd
> expect with a unix filesystem.

Agreed. I don't think these changes are necessary in any case.

https://codereview.chromium.org/1258123004/diff/140001/platform_tools/android...
File platform_tools/android/apps/canvasproof/build.gradle (right):

https://codereview.chromium.org/1258123004/diff/140001/platform_tools/android...
platform_tools/android/apps/canvasproof/build.gradle:10: buildToolsVersion
"22.0.1"
On 2015/08/22 19:15:52, tomhudson wrote:
> Nit: this is significantly newer than necessary for SDK 19, if I'm reading
> https://developer.android.com/tools/revisions/build-tools.html right.

This is correct and lines up with the build tools we use for building all the
other apps.

https://codereview.chromium.org/1258123004/diff/140001/platform_tools/android...
platform_tools/android/apps/canvasproof/build.gradle:21:
applicationVariants.all{ variant ->
I wonder if gradle has some include structure so that we don't need to copy this
code every time. The only thing that changes between the copies is the name of
the gyp target.

https://codereview.chromium.org/1258123004/diff/140001/platform_tools/android...
File platform_tools/android/apps/canvasproof/src/main/AndroidManifest.xml
(right):

https://codereview.chromium.org/1258123004/diff/140001/platform_tools/android...
platform_tools/android/apps/canvasproof/src/main/AndroidManifest.xml:20:
<meta-data android:name="android.app.lib_name"
is this necessary?

https://codereview.chromium.org/1258123004/diff/140001/platform_tools/android...
File
platform_tools/android/apps/canvasproof/src/main/java/org/skia/canvasproof/CanvasProofActivity.java
(right):

https://codereview.chromium.org/1258123004/diff/140001/platform_tools/android...
platform_tools/android/apps/canvasproof/src/main/java/org/skia/canvasproof/CanvasProofActivity.java:182:
private GaneshPictureRenderer ganeshPictureRenderer;
java style is to put the member variables at the top of the file.

https://codereview.chromium.org/1258123004/diff/140001/platform_tools/android...
File
platform_tools/android/apps/canvasproof/src/main/java/org/skia/canvasproof/CreateSkiaPicture.java
(right):

https://codereview.chromium.org/1258123004/diff/140001/platform_tools/android...
platform_tools/android/apps/canvasproof/src/main/java/org/skia/canvasproof/CreateSkiaPicture.java:44:
public static void delete(long ptr) {
spaces between java methods.

https://codereview.chromium.org/1258123004/diff/140001/platform_tools/android...
File platform_tools/android/apps/canvasproof/src/main/jni/Debugf.h (right):

https://codereview.chromium.org/1258123004/diff/140001/platform_tools/android...
platform_tools/android/apps/canvasproof/src/main/jni/Debugf.h:12:
__android_log_print(ANDROID_LOG_VERBOSE, DTAG, __VA_ARGS__)
why is SkDebugf not good enough?

[tomhudson, 2015-08-24 20:10:25]

How the other half reviews:

https://codereview.chromium.org/1258123004/diff/160001/platform_tools/android...
File platform_tools/android/apps/canvasproof/src/main/AndroidManifest.xml
(right):

https://codereview.chromium.org/1258123004/diff/160001/platform_tools/android...
platform_tools/android/apps/canvasproof/src/main/AndroidManifest.xml:10:
package="com.skia.canvasproof"
You're building from org/skia/canvasproof, but the manifest says com?

https://codereview.chromium.org/1258123004/diff/160001/platform_tools/android...
File
platform_tools/android/apps/canvasproof/src/main/java/org/skia/canvasproof/CanvasProofActivity.java
(right):

https://codereview.chromium.org/1258123004/diff/160001/platform_tools/android...
platform_tools/android/apps/canvasproof/src/main/java/org/skia/canvasproof/CanvasProofActivity.java:11:
import android.content.Context;
Am I missing where you use this new import?

https://codereview.chromium.org/1258123004/diff/160001/platform_tools/android...
File
platform_tools/android/apps/canvasproof/src/main/java/org/skia/canvasproof/CreateSkiaPicture.java
(right):

https://codereview.chromium.org/1258123004/diff/160001/platform_tools/android...
platform_tools/android/apps/canvasproof/src/main/java/org/skia/canvasproof/CreateSkiaPicture.java:34:
byte[] buffer = new byte[16384];
Nit: magic number? (I suppose it doesn't matter here.)

https://codereview.chromium.org/1258123004/diff/160001/platform_tools/android...
File
platform_tools/android/apps/canvasproof/src/main/java/org/skia/canvasproof/GaneshPictureRenderer.java
(right):

https://codereview.chromium.org/1258123004/diff/160001/platform_tools/android...
platform_tools/android/apps/canvasproof/src/main/java/org/skia/canvasproof/GaneshPictureRenderer.java:37:
public android.opengl.GLSurfaceView makeView(
Nit: You've imported GLSurfaceView; do you really need to fully qualify it here?

https://codereview.chromium.org/1258123004/diff/160001/platform_tools/android...
File
platform_tools/android/apps/canvasproof/src/main/java/org/skia/canvasproof/HwuiPictureView.java
(right):

https://codereview.chromium.org/1258123004/diff/160001/platform_tools/android...
platform_tools/android/apps/canvasproof/src/main/java/org/skia/canvasproof/HwuiPictureView.java:31:
@SuppressWarnings("deprecation")  // purposely using this
Tell us why.
(Also, this doesn't seem to be @override, or at least I can't find it listed at
all in the android.view.View docs - so what's triggering the deprecation
warning?)

https://codereview.chromium.org/1258123004/diff/160001/platform_tools/android...
File
platform_tools/android/apps/canvasproof/src/main/jni/org_skia_canvasproof_CreateSkiaPicture.cpp
(right):

https://codereview.chromium.org/1258123004/diff/160001/platform_tools/android...
platform_tools/android/apps/canvasproof/src/main/jni/org_skia_canvasproof_CreateSkiaPicture.cpp:31:
#if 0
What's up with the #if 0'd code?

https://codereview.chromium.org/1258123004/diff/160001/platform_tools/android...
File
platform_tools/android/apps/canvasproof/src/main/jni/org_skia_canvasproof_GaneshPictureRenderer.cpp
(right):

https://codereview.chromium.org/1258123004/diff/160001/platform_tools/android...
platform_tools/android/apps/canvasproof/src/main/jni/org_skia_canvasproof_GaneshPictureRenderer.cpp:53:
Debugf(TAG, "RENDER TIME: %d", dur);
These are *really* noisy in practice, at least in part because we spend some
time suspended and all you're reporting here seems to be wallclock. Consider
removing?

https://codereview.chromium.org/1258123004/diff/160001/platform_tools/android...
File platform_tools/android/gyp/canvasproof.gypi (right):

https://codereview.chromium.org/1258123004/diff/160001/platform_tools/android...
platform_tools/android/gyp/canvasproof.gypi:65:
':canvasproof:assemble<(android_variant)Debug',
Looks like this is where the hardwired "Debug" in the name comes from.

[hal.canary, 2015-08-31 21:16:56]

https://codereview.chromium.org/1258123004/diff/140001/.gitignore
File .gitignore (right):

https://codereview.chromium.org/1258123004/diff/140001/.gitignore#newcode27
.gitignore:27: /tools/skp/page_sets/data/*.wpr
On 2015/08/22 19:15:51, tomhudson wrote:
> Why add leading slashes, particularly to some but not all? This is not what
I'd
> expect with a unix filesystem.

Quoting from `man gitignore | grep -A1 'leading slash'`: 'A leading slash
matches the beginning of the pathname. For example, "/*.c" matches "cat-file.c"
but not "mozilla-sha1/sha1.c".'

https://codereview.chromium.org/1258123004/diff/140001/.gitignore#newcode27
.gitignore:27: /tools/skp/page_sets/data/*.wpr
On 2015/08/24 12:42:56, djsollen wrote:
> On 2015/08/22 19:15:51, tomhudson wrote:
> > Why add leading slashes, particularly to some but not all? This is not what
> I'd
> > expect with a unix filesystem.
> 
> Agreed. I don't think these changes are necessary in any case.

Done, except for the one I wanted.

https://codereview.chromium.org/1258123004/diff/140001/platform_tools/android...
File platform_tools/android/apps/canvasproof/build.gradle (right):

https://codereview.chromium.org/1258123004/diff/140001/platform_tools/android...
platform_tools/android/apps/canvasproof/build.gradle:19:
sourceSets.main.jniLibs.srcDir "src/main/libs"
On 2015/08/22 19:15:52, tomhudson wrote:
> Doesn't this need = ?

Done.

https://codereview.chromium.org/1258123004/diff/140001/platform_tools/android...
File platform_tools/android/apps/canvasproof/src/main/AndroidManifest.xml
(right):

https://codereview.chromium.org/1258123004/diff/140001/platform_tools/android...
platform_tools/android/apps/canvasproof/src/main/AndroidManifest.xml:20:
<meta-data android:name="android.app.lib_name"
On 2015/08/24 12:42:56, djsollen wrote:
> is this necessary?

It doesn't load the libraries otherwise.

https://codereview.chromium.org/1258123004/diff/140001/platform_tools/android...
File
platform_tools/android/apps/canvasproof/src/main/java/org/skia/canvasproof/CanvasProofActivity.java
(right):

https://codereview.chromium.org/1258123004/diff/140001/platform_tools/android...
platform_tools/android/apps/canvasproof/src/main/java/org/skia/canvasproof/CanvasProofActivity.java:59:
Log.e(TAG, "IOException in getAssetPaths", e);
On 2015/08/22 19:15:52, tomhudson wrote:
> Can you more explicitly list what failed here? Not knowing where to install
> assets is a common failure mode, and good error messages are a backstop to
good
> documentation.

Done.

https://codereview.chromium.org/1258123004/diff/140001/platform_tools/android...
platform_tools/android/apps/canvasproof/src/main/java/org/skia/canvasproof/CanvasProofActivity.java:63:
Log.e(TAG, "this.getAssets().getAssetPaths returned null");
On 2015/08/22 19:15:52, tomhudson wrote:
> How about "found no resources in path <directory>"?
> Isn't a non-null but 0-length resources also something we should be erroring
on?

Done.

https://codereview.chromium.org/1258123004/diff/140001/platform_tools/android...
platform_tools/android/apps/canvasproof/src/main/java/org/skia/canvasproof/CanvasProofActivity.java:71:
Log.v(TAG, "loading " + path);
On 2015/08/22 19:15:52, tomhudson wrote:
> If we don't need these logs any more, please strip them out before committing
-
> Android logspam is nasty tragedy of the commons.

Done.  I've removed all Log.v();

https://codereview.chromium.org/1258123004/diff/140001/platform_tools/android...
platform_tools/android/apps/canvasproof/src/main/java/org/skia/canvasproof/CanvasProofActivity.java:149:
this.hwuiPictureView
On 2015/08/22 19:15:52, tomhudson wrote:
> If HwuiPictureView extends View, why have another anonymous view here wrapping
> it instead of just setting its layout params and adding it directly?

Done.

https://codereview.chromium.org/1258123004/diff/140001/platform_tools/android...
platform_tools/android/apps/canvasproof/src/main/java/org/skia/canvasproof/CanvasProofActivity.java:182:
private GaneshPictureRenderer ganeshPictureRenderer;
On 2015/08/24 12:42:56, djsollen wrote:
> java style is to put the member variables at the top of the file.

Done.

https://codereview.chromium.org/1258123004/diff/140001/platform_tools/android...
File
platform_tools/android/apps/canvasproof/src/main/java/org/skia/canvasproof/CreateSkiaPicture.java
(right):

https://codereview.chromium.org/1258123004/diff/140001/platform_tools/android...
platform_tools/android/apps/canvasproof/src/main/java/org/skia/canvasproof/CreateSkiaPicture.java:44:
public static void delete(long ptr) {
On 2015/08/24 12:42:56, djsollen wrote:
> spaces between java methods.

Done.

https://codereview.chromium.org/1258123004/diff/140001/platform_tools/android...
File platform_tools/android/apps/canvasproof/src/main/jni/Debugf.h (right):

https://codereview.chromium.org/1258123004/diff/140001/platform_tools/android...
platform_tools/android/apps/canvasproof/src/main/jni/Debugf.h:12:
__android_log_print(ANDROID_LOG_VERBOSE, DTAG, __VA_ARGS__)
On 2015/08/24 12:42:56, djsollen wrote:
> why is SkDebugf not good enough?

Done.

https://codereview.chromium.org/1258123004/diff/160001/platform_tools/android...
File platform_tools/android/apps/canvasproof/src/main/AndroidManifest.xml
(right):

https://codereview.chromium.org/1258123004/diff/160001/platform_tools/android...
platform_tools/android/apps/canvasproof/src/main/AndroidManifest.xml:10:
package="com.skia.canvasproof"
On 2015/08/24 20:10:25, tomhudson wrote:
> You're building from org/skia/canvasproof, but the manifest says com?

Done.

https://codereview.chromium.org/1258123004/diff/160001/platform_tools/android...
File
platform_tools/android/apps/canvasproof/src/main/java/org/skia/canvasproof/CanvasProofActivity.java
(right):

https://codereview.chromium.org/1258123004/diff/160001/platform_tools/android...
platform_tools/android/apps/canvasproof/src/main/java/org/skia/canvasproof/CanvasProofActivity.java:11:
import android.content.Context;
On 2015/08/24 20:10:25, tomhudson wrote:
> Am I missing where you use this new import?

No longer needed.

https://codereview.chromium.org/1258123004/diff/160001/platform_tools/android...
File
platform_tools/android/apps/canvasproof/src/main/java/org/skia/canvasproof/CreateSkiaPicture.java
(right):

https://codereview.chromium.org/1258123004/diff/160001/platform_tools/android...
platform_tools/android/apps/canvasproof/src/main/java/org/skia/canvasproof/CreateSkiaPicture.java:34:
byte[] buffer = new byte[16384];
On 2015/08/24 20:10:25, tomhudson wrote:
> Nit: magic number? (I suppose it doesn't matter here.)

Done.

https://codereview.chromium.org/1258123004/diff/160001/platform_tools/android...
File
platform_tools/android/apps/canvasproof/src/main/java/org/skia/canvasproof/GaneshPictureRenderer.java
(right):

https://codereview.chromium.org/1258123004/diff/160001/platform_tools/android...
platform_tools/android/apps/canvasproof/src/main/java/org/skia/canvasproof/GaneshPictureRenderer.java:37:
public android.opengl.GLSurfaceView makeView(
On 2015/08/24 20:10:25, tomhudson wrote:
> Nit: You've imported GLSurfaceView; do you really need to fully qualify it
here?

Done.

For consistency, I'm prefer import statements to fully-qualified names.  But I
forgot here.

https://codereview.chromium.org/1258123004/diff/160001/platform_tools/android...
File
platform_tools/android/apps/canvasproof/src/main/java/org/skia/canvasproof/HwuiPictureView.java
(right):

https://codereview.chromium.org/1258123004/diff/160001/platform_tools/android...
platform_tools/android/apps/canvasproof/src/main/java/org/skia/canvasproof/HwuiPictureView.java:31:
@SuppressWarnings("deprecation")  // purposely using this
On 2015/08/24 20:10:25, tomhudson wrote:
> Tell us why.
> (Also, this doesn't seem to be @override, or at least I can't find it listed
at
> all in the android.view.View docs - so what's triggering the deprecation
> warning?)

removed.

Dang.  This was taking an input stream rather than a Picture before I changed
it.

https://codereview.chromium.org/1258123004/diff/160001/platform_tools/android...
File
platform_tools/android/apps/canvasproof/src/main/jni/org_skia_canvasproof_CreateSkiaPicture.cpp
(right):

https://codereview.chromium.org/1258123004/diff/160001/platform_tools/android...
platform_tools/android/apps/canvasproof/src/main/jni/org_skia_canvasproof_CreateSkiaPicture.cpp:31:
#if 0
On 2015/08/24 20:10:25, tomhudson wrote:
> What's up with the #if 0'd code?

This is a test we should perform: does using a BBH make things faster?

https://codereview.chromium.org/1258123004/diff/160001/platform_tools/android...
File
platform_tools/android/apps/canvasproof/src/main/jni/org_skia_canvasproof_GaneshPictureRenderer.cpp
(right):

https://codereview.chromium.org/1258123004/diff/160001/platform_tools/android...
platform_tools/android/apps/canvasproof/src/main/jni/org_skia_canvasproof_GaneshPictureRenderer.cpp:53:
Debugf(TAG, "RENDER TIME: %d", dur);
On 2015/08/24 20:10:25, tomhudson wrote:
> These are *really* noisy in practice, at least in part because we spend some
> time suspended and all you're reporting here seems to be wallclock. Consider
> removing?

Done.

https://codereview.chromium.org/1258123004/diff/160001/platform_tools/android...
File platform_tools/android/gyp/canvasproof.gypi (right):

https://codereview.chromium.org/1258123004/diff/160001/platform_tools/android...
platform_tools/android/gyp/canvasproof.gypi:65:
':canvasproof:assemble<(android_variant)Debug',
On 2015/08/24 20:10:25, tomhudson wrote:
> Looks like this is where the hardwired "Debug" in the name comes from.

I do not know how this works.

[djsollen, 2015-09-01 13:06:24]

https://codereview.chromium.org/1258123004/diff/140001/platform_tools/android...
File platform_tools/android/apps/canvasproof/src/main/AndroidManifest.xml
(right):

https://codereview.chromium.org/1258123004/diff/140001/platform_tools/android...
platform_tools/android/apps/canvasproof/src/main/AndroidManifest.xml:20:
<meta-data android:name="android.app.lib_name"
On 2015/08/31 21:16:55, Hal Canary wrote:
> On 2015/08/24 12:42:56, djsollen wrote:
> > is this necessary?
> 
> It doesn't load the libraries otherwise.

I thought you just needed to use System.LoadLibrary.

[djsollen, 2015-09-01 13:13:29]

https://codereview.chromium.org/1258123004/diff/180001/.gitignore
File .gitignore (right):

https://codereview.chromium.org/1258123004/diff/180001/.gitignore#newcode24
.gitignore:24: /skps
should we ignore all *.skp?

https://codereview.chromium.org/1258123004/diff/180001/platform_tools/android...
File platform_tools/android/apps/canvasproof/build.gradle (right):

https://codereview.chromium.org/1258123004/diff/180001/platform_tools/android...
platform_tools/android/apps/canvasproof/build.gradle:16: versionName "1.0"
add

signingConfig signingConfigs.debug

https://codereview.chromium.org/1258123004/diff/180001/platform_tools/android...
File
platform_tools/android/apps/canvasproof/src/main/java/org/skia/canvasproof/CreateSkiaPicture.java
(right):

https://codereview.chromium.org/1258123004/diff/180001/platform_tools/android...
platform_tools/android/apps/canvasproof/src/main/java/org/skia/canvasproof/CreateSkiaPicture.java:56:
public static native void deleteImpl(long ptr);
does this need to be public?

https://codereview.chromium.org/1258123004/diff/180001/platform_tools/android...
File
platform_tools/android/apps/canvasproof/src/main/java/org/skia/canvasproof/HwuiPictureView.java
(right):

https://codereview.chromium.org/1258123004/diff/180001/platform_tools/android...
platform_tools/android/apps/canvasproof/src/main/java/org/skia/canvasproof/HwuiPictureView.java:53:
// Is p.draw(canvas) slower?
not really.

[tomhudson, 2015-09-16 14:53:19]

PING!

[hal.canary, 2015-09-16 18:31:34]

Let's land this!

https://codereview.chromium.org/1258123004/diff/180001/platform_tools/android...
File
platform_tools/android/apps/canvasproof/src/main/java/org/skia/canvasproof/CreateSkiaPicture.java
(right):

https://codereview.chromium.org/1258123004/diff/180001/platform_tools/android...
platform_tools/android/apps/canvasproof/src/main/java/org/skia/canvasproof/CreateSkiaPicture.java:56:
public static native void deleteImpl(long ptr);
On 2015/09/01 13:13:29, djsollen wrote:
> does this need to be public?

nope.  fixed.

https://codereview.chromium.org/1258123004/diff/180001/platform_tools/android...
File
platform_tools/android/apps/canvasproof/src/main/java/org/skia/canvasproof/HwuiPictureView.java
(right):

https://codereview.chromium.org/1258123004/diff/180001/platform_tools/android...
platform_tools/android/apps/canvasproof/src/main/java/org/skia/canvasproof/HwuiPictureView.java:53:
// Is p.draw(canvas) slower?
On 2015/09/01 13:13:29, djsollen wrote:
> not really.

Acknowledged.

[hal.canary, 2015-09-22 15:07:23]

ping

[djsollen, 2015-09-22 15:53:53]

Tom can you review the Java code?  The gyp files and build setup look good.

https://codereview.chromium.org/1258123004/diff/200001/.gitignore
File .gitignore (right):

https://codereview.chromium.org/1258123004/diff/200001/.gitignore#newcode24
.gitignore:24: /skps
why is this needed?

https://codereview.chromium.org/1258123004/diff/200001/platform_tools/android...
File platform_tools/android/apps/canvasproof/src/main/assets/skps/.gitignore
(right):

https://codereview.chromium.org/1258123004/diff/200001/platform_tools/android...
platform_tools/android/apps/canvasproof/src/main/assets/skps/.gitignore:1: *.skp
why do you need both .gitignore changes?

[tomhudson, 2015-09-23 16:16:08]

lgtm

[hal.canary, 2015-09-23 16:17:31]

The CQ bit was checked by halcanary@google.com

[commit-bot: I haz the power, 2015-09-23 16:17:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1258123004/200001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1258123004/200001

[hal.canary, 2015-09-23 16:21:40]

The CQ bit was unchecked by halcanary@google.com

[hal.canary, 2015-09-23 19:39:30]

https://codereview.chromium.org/1258123004/diff/200001/platform_tools/android...
File platform_tools/android/apps/canvasproof/src/main/assets/skps/.gitignore
(right):

https://codereview.chromium.org/1258123004/diff/200001/platform_tools/android...
platform_tools/android/apps/canvasproof/src/main/assets/skps/.gitignore:1: *.skp
On 2015/09/22 15:53:53, djsollen wrote:
> why do you need both .gitignore changes?

I am trying to force creation of the /main/assets/skps directly.  Without the
change to the top-level .gitignore, the directory is invisible to git.

[hal.canary, 2015-09-23 19:39:37]

The CQ bit was checked by halcanary@google.com

[commit-bot: I haz the power, 2015-09-23 19:39:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1258123004/200001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1258123004/200001

[commit-bot: I haz the power, 2015-09-23 19:40:41]

Committed patchset #9 (id:200001) as
https://skia.googlesource.com/skia/+/ab26a9b427ec7c525ccd0025f19f0c91b74d8f6d