Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 1257693002: [telemetry] Add support for requesting memory dumps via extension API (Closed)

Created:
5 years, 5 months ago by petrcermak
Modified:
5 years, 4 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[telemetry] Add support for requesting memory dumps via extension API This patch (together with https://codereview.chromium.org/1245233004/) will allow telemetry memory page interactions to request memory dumps as follows: action_runner.tab.DumpMemory() Note that this patch is a replacement for https://codereview.chromium.org/1224083015/. BUG=505826

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -0 lines) Patch
M tools/telemetry/telemetry/internal/browser/tab.py View 1 chunk +23 lines, -0 lines 1 comment Download
M tools/telemetry/telemetry/internal/browser/tab_unittest.py View 1 chunk +47 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
petrcermak
5 years, 5 months ago (2015-07-24 12:35:17 UTC) #2
Primiano Tucci (use gerrit)
LGTM once ned approves. Ned: apologies for the double round. We had to change strategy ...
5 years, 5 months ago (2015-07-24 14:33:29 UTC) #4
nednguyen
On 2015/07/24 14:33:29, Primiano Tucci (OOO til Aug 9) wrote: > LGTM once ned approves. ...
5 years, 5 months ago (2015-07-24 14:50:46 UTC) #5
petrcermak
5 years, 4 months ago (2015-07-29 16:40:16 UTC) #6
Message was sent while issue was closed.
After some discussions we decided to go back to the original DevTools API
solution (https://codereview.chromium.org/1224083015/), so this patch was
abandoned.

Powered by Google App Engine
This is Rietveld 408576698