Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Unified Diff: tools/telemetry/telemetry/internal/browser/tab.py

Issue 1257693002: [telemetry] Add support for requesting memory dumps via extension API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/telemetry/telemetry/internal/browser/tab_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/internal/browser/tab.py
diff --git a/tools/telemetry/telemetry/internal/browser/tab.py b/tools/telemetry/telemetry/internal/browser/tab.py
index 9c1f79f9e16471b44df3ff6fc4036d0fd04435c2..f78c2297f4e92a9ab280b583dd89f24cb04abaa2 100644
--- a/tools/telemetry/telemetry/internal/browser/tab.py
+++ b/tools/telemetry/telemetry/internal/browser/tab.py
@@ -257,3 +257,26 @@ class Tab(web_contents.WebContents):
""")
if force:
self.Navigate('about:blank')
+
+ def DumpMemory(self, timeout=DEFAULT_TAB_TIMEOUT):
+ """Dumps memory.
+
+ Returns:
+ GUID of the generated dump if successful, None otherwise.
+
+ Raises:
+ exceptions.EvaluateException
+ exceptions.WebSocketDisconnected
+ exceptions.TimeoutException
+ exceptions.DevtoolsTargetCrashException
+ """
+ self.ExecuteJavaScript("""
+ window.__telemetry_memory_dump_guid = undefined;
+ chrome.memoryBenchmarking.requestMemoryDump(function(dumpGuid, success) {
+ window.__telemetry_memory_dump_guid = success ? dumpGuid : null;
+ });
+ """, timeout)
+ self.WaitForJavaScriptExpression(
+ 'window.__telemetry_memory_dump_guid !== undefined', timeout)
+ return self.EvaluateJavaScript(
+ 'window.__telemetry_memory_dump_guid', timeout)
Primiano Tucci (use gerrit) 2015/07/24 14:33:29 maybe you walso want to clear the global __telemet
« no previous file with comments | « no previous file | tools/telemetry/telemetry/internal/browser/tab_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698