Make CrWinClangLLD bot do 32-bit builds, add a CrWinClangLLD64 bot.

Make CrWinClangLLD bot do 32-bit builds, add a CrWinClangLLD64 bot.

BUG=82385
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=296139

[Nico, 2015-07-28 04:07:48]

thakis@chromium.org changed reviewers:
+ hans@chromium.org

[Nico, 2015-07-28 04:08:46]

thakis@chromium.org changed reviewers:
+ akuegel@chromium.org

[Nico, 2015-07-28 04:08:47]

+akuegel for fyi owners

[Adrian Kuegel, 2015-07-28 15:01:06]

lgtm

https://codereview.chromium.org/1257683007/diff/40001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py (right):

https://codereview.chromium.org/1257683007/diff/40001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py:623:
'add_tests_as_compile_targets': False,
Small comment: you could just specify compile_targets as "all". I think then you
would not need this.

[Nico, 2015-07-28 15:11:16]

Thanks!

https://codereview.chromium.org/1257683007/diff/40001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py (right):

https://codereview.chromium.org/1257683007/diff/40001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py:623:
'add_tests_as_compile_targets': False,
On 2015/07/28 15:01:06, Adrian Kuegel wrote:
> Small comment: you could just specify compile_targets as "all". I think then
you
> would not need this.

I want the bot to build the default target. (Also, then I end up with "all" and
a bunch of test binaries on the build line, which can be different from building
just "all" – "all" currently means "all targets transitively reachable from
targets listed build/all.gyp", not "all targets in all gyp files transitively
reachable from build/all.gyp")

[Adrian Kuegel, 2015-07-28 15:15:33]

On 2015/07/28 15:11:16, Nico (vacation Mon Jul 27) wrote:
> Thanks!
> 
>
https://codereview.chromium.org/1257683007/diff/40001/scripts/slave/recipe_mo...
> File scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py (right):
> 
>
https://codereview.chromium.org/1257683007/diff/40001/scripts/slave/recipe_mo...
> scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py:623:
> 'add_tests_as_compile_targets': False,
> On 2015/07/28 15:01:06, Adrian Kuegel wrote:
> > Small comment: you could just specify compile_targets as "all". I think then
> you
> > would not need this.
> 
> I want the bot to build the default target. (Also, then I end up with "all"
and
> a bunch of test binaries on the build line, which can be different from
building
> just "all" – "all" currently means "all targets transitively reachable
from
> targets listed build/all.gyp", not "all targets in all gyp files transitively
> reachable from build/all.gyp")

Hmm, not sure I understand this correctly, but lets say no test targets are
added and you just build "all", is this still different than building the
default target?
Anyway, feel free to land this CL, this was just an optional comment.

[Nico, 2015-07-28 15:30:47]

On 2015/07/28 15:15:33, Adrian Kuegel wrote:
> On 2015/07/28 15:11:16, Nico (vacation Mon Jul 27) wrote:
> > Thanks!
> > 
> >
>
https://codereview.chromium.org/1257683007/diff/40001/scripts/slave/recipe_mo...
> > File scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py (right):
> > 
> >
>
https://codereview.chromium.org/1257683007/diff/40001/scripts/slave/recipe_mo...
> > scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py:623:
> > 'add_tests_as_compile_targets': False,
> > On 2015/07/28 15:01:06, Adrian Kuegel wrote:
> > > Small comment: you could just specify compile_targets as "all". I think
then
> > you
> > > would not need this.
> > 
> > I want the bot to build the default target. (Also, then I end up with "all"
> and
> > a bunch of test binaries on the build line, which can be different from
> building
> > just "all" – "all" currently means "all targets transitively reachable
> from
> > targets listed build/all.gyp", not "all targets in all gyp files
transitively
> > reachable from build/all.gyp")
> 
> Hmm, not sure I understand this correctly, but lets say no test targets are
> added and you just build "all", is this still different than building the
> default target?

If no other test targets are on the build line, then the default target is
currently the same as 'all' in practice. This isn't necessarily the case though;
you can pass -Gdefault_target=chrome to gyp to make chrome the default target
for example (and chrome/android used to build a target different than all by
default, until I fixed that.)

[Nico, 2015-07-28 15:30:56]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2015-07-28 15:31:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1257683007/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1257683007/40001

[commit-bot: I haz the power, 2015-07-28 15:36:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-28 15:36:49]

Try jobs failed on following builders:
  build_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/build_presubmit...)

[Nico, 2015-07-28 15:41:02]

The CQ bit was checked by thakis@chromium.org

[Nico, 2015-07-28 15:41:03]

The patchset sent to the CQ was uploaded after l-g-t-m from akuegel@chromium.org
Link to the patchset: https://codereview.chromium.org/1257683007/#ps60001
(title: ".")

[commit-bot: I haz the power, 2015-07-28 15:41:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1257683007/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1257683007/60001

[commit-bot: I haz the power, 2015-07-28 15:44:36]

Committed patchset #4 (id:60001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=296139