Subzero. Buildable, non-functional TargetLoweringX8664.

src/IceTargetLoweringX8632.h

Index: src/IceTargetLoweringX8632.h
diff --git a/src/IceTargetLoweringX8632.h b/src/IceTargetLoweringX8632.h
index 1f1d2cb0a2555507fc692c408b6044a93d40c8e4..f89d6ca451c676e72c1b071c2896702cd94f832c 100644
--- a/src/IceTargetLoweringX8632.h
+++ b/src/IceTargetLoweringX8632.h
@@ -38,7 +38,9 @@ public:
 
   static TargetX8632 *create(Cfg *Func) { return new TargetX8632(Func); }
 
-protected:
+private:
+  friend class ::Ice::X86Internal::TargetX86Base<TargetX8632>;
+
   Operand *createNaClReadTPSrcOperand() {
     Constant *Zero = Ctx->getConstantZero(IceType_i32);
     return Traits::X86OperandMem::create(Func, IceType_i32, nullptr, Zero,
@@ -47,8 +49,6 @@ protected:
   }
 
 private:

[jvoung (off chromium), 2015/07/30 21:16:21]

This "private:" is already covered by the (new) previous one?

[John, 2015/07/31 21:05:54]

Done.

-  friend class ::Ice::X86Internal::TargetX86Base<TargetX8632>;
-
   explicit TargetX8632(Cfg *Func) : TargetX86Base(Func) {}
 };
 
@@ -58,19 +58,20 @@ class TargetDataX8632 final : public TargetDataLowering {
   TargetDataX8632 &operator=(const TargetDataX8632 &) = delete;
 
 public:
+  ~TargetDataX8632() override = default;
+
   static std::unique_ptr<TargetDataLowering> create(GlobalContext *Ctx) {
-    return std::unique_ptr<TargetDataLowering>(new TargetDataX8632(Ctx));
+    return makeUnique<TargetDataX8632>(Ctx);
   }
 
   void lowerGlobals(const VariableDeclarationList &Vars,
                     const IceString &SectionSuffix) override;
   void lowerConstants() override;
 
-protected:
-  explicit TargetDataX8632(GlobalContext *Ctx);
-
 private:
-  ~TargetDataX8632() override = default;
+  ENABLE_MAKE_UNIQUE;
+
+  explicit TargetDataX8632(GlobalContext *Ctx);
   template <typename T> static void emitConstantPool(GlobalContext *Ctx);
 };