Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: chrome/common/BUILD.gn

Issue 1257633002: Componentize VersionInfo. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix OWNERS (copy from //chrome/OWNERS) Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/BUILD.gn
diff --git a/chrome/common/BUILD.gn b/chrome/common/BUILD.gn
index fc85ced6f94a3639c29a0985929e9ad6008a26cf..23fc42cee150c3ce2ef82ff50d8f856740796926 100644
--- a/chrome/common/BUILD.gn
+++ b/chrome/common/BUILD.gn
@@ -48,7 +48,6 @@ static_library("common") {
"//chrome/common/safe_browsing:proto",
]
deps = [
- ":version",
"//base:base",
"//base:i18n",
"//base:prefs",
@@ -69,6 +68,7 @@ static_library("common") {
"//components/policy:policy_component_common",
"//components/translate/core/common",
"//components/variations",
+ "//components/version_info",
"//content/public/common",
"//crypto",
"//extensions/common:common_constants",
@@ -260,12 +260,6 @@ source_set("result_codes") {
}
import("//chrome/version.gni")
brettw 2015/07/27 19:42:31 This is kind of weird here, can you move it to the
sdefresne 2015/07/28 08:58:26 Done.
-process_version("version") {
- visibility = [ ":common" ]
- template_file = "chrome_version_info_values.h.version"
- output = "$target_gen_dir/chrome_version_info_values.h"
-}
-
process_version("make_chrome_version") {
template_file = "chrome_version.cc.version"
output = "$target_gen_dir/chrome_version.cc"

Powered by Google App Engine
This is Rietveld 408576698