Componentize VersionInfo.

chrome/common/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//tools/grit/grit_rule.gni")
 import("//third_party/mojo/src/mojo/public/tools/bindings/mojom.gni")
 
 gypi_values = exec_script("//build/gypi_to_gn.py",
                           [ rebase_path("../chrome_common.gypi") ],
                           "scope",
@@ skipping 30 matching lines @@
   defines = []
 
   configs += [ "//build/config/compiler:wexit_time_destructors" ]
 
   public_deps = [
     "//chrome/common:constants",
     "//chrome/common/net",
     "//chrome/common/safe_browsing:proto",
   ]
   deps = [
-    ":version",
     "//base:base",
     "//base:i18n",
     "//base:prefs",
     "//base:base_static",
     "//chrome:resources",
     "//chrome:strings",
     "//chrome/app/theme:theme_resources",
     "//chrome/common/variations:fieldtrial_testing_config",
     "//chrome/installer/util",
     "//components/cloud_devices/common",
     "//components/component_updater",
     "//components/content_settings/core/common",
     "//components/favicon_base",
     "//components/gcm_driver/common",
     "//components/json_schema",
     "//components/metrics",
     "//components/omnibox/common",
     "//components/policy:policy_component_common",
     "//components/translate/core/common",
     "//components/variations",
+    "//components/version_info",
     "//content/public/common",
     "//crypto",
     "//extensions/common:common_constants",
     "//net",
     "//skia",
     "//third_party/icu",
     "//third_party/zlib:zip",
     "//ui/resources:resources",
     "//url",
   ]
@@ skipping 170 matching lines @@
 }
 
 # This target allows other targets to depend on result_codes.h which is a
 # header-only dependency, without bringing in all of content.
 source_set("result_codes") {
   sources = [
     "chrome_result_codes.h",
   ]
 }
 
 import("//chrome/version.gni")

[brettw, 2015/07/27 19:42:31]

This is kind of weird here, can you move it to the top of the file like we would
a C include?

[sdefresne, 2015/07/28 08:58:26]

Done.

-process_version("version") {
-  visibility = [ ":common" ]
-  template_file = "chrome_version_info_values.h.version"
-  output = "$target_gen_dir/chrome_version_info_values.h"
-}
-
 process_version("make_chrome_version") {
   template_file = "chrome_version.cc.version"
   output = "$target_gen_dir/chrome_version.cc"
 }
 
 # GN version: chrome/common_constants.gyp:common_constants
 static_library("constants") {
   sources = [
     "chrome_constants.cc",
     "chrome_constants.h",
@@ skipping 77 matching lines @@
     ":constants",
     "//base",
   ]
 }
 
 mojom("mojo_bindings") {
   sources = [
     "resource_usage_reporter.mojom",
   ]
 }