chrome/browser/extensions/api/idltest/idltest_apitest.cc - Issue 1257633002: Componentize VersionInfo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/idltest/idltest_apitest.cc

Issue 1257633002: Componentize VersionInfo. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Convert version_info::Channel to a "class enum" Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/idltest/idltest_apitest.cc

diff --git a/chrome/browser/extensions/api/idltest/idltest_apitest.cc b/chrome/browser/extensions/api/idltest/idltest_apitest.cc

index 57eae4afd233faefc3ec130bda2652d8932ec7bb..c823c3f02e7820572364a6180bd7fdebc94667c3 100644

--- a/chrome/browser/extensions/api/idltest/idltest_apitest.cc

+++ b/chrome/browser/extensions/api/idltest/idltest_apitest.cc

@@ -9,7 +9,7 @@

class ExtensionIdltestApiTest : public ExtensionApiTest {

public:

// Set the channel to "trunk" since idltest is restricted to trunk.

- ExtensionIdltestApiTest() : trunk_(chrome::VersionInfo::CHANNEL_UNKNOWN) {}

+ ExtensionIdltestApiTest() : trunk_(version_info::Channel::UNKNOWN) {}

~ExtensionIdltestApiTest() override {}

private: