chrome/browser/extensions/api/idltest/idltest_apitest.cc - Issue 1257633002: Componentize VersionInfo.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/extensions/api/idltest/idltest_apitest.cc

Issue 1257633002: Componentize VersionInfo. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Convert version_info::Channel to a "class enum" Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/extensions/api/declarative_content/set_icon_apitest.cc ('k') | chrome/browser/extensions/api/instance_id/instance_id_apitest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/extensions/extension_apitest.h"	5 #include "chrome/browser/extensions/extension_apitest.h"

6 #include "chrome/common/extensions/features/feature_channel.h"	6 #include "chrome/common/extensions/features/feature_channel.h"

7 #include "extensions/common/switches.h"	7 #include "extensions/common/switches.h"

8	8

9 class ExtensionIdltestApiTest : public ExtensionApiTest {	9 class ExtensionIdltestApiTest : public ExtensionApiTest {

10 public:	10 public:

11 // Set the channel to "trunk" since idltest is restricted to trunk.	11 // Set the channel to "trunk" since idltest is restricted to trunk.

12 ExtensionIdltestApiTest() : trunk_(chrome::VersionInfo::CHANNEL_UNKNOWN) {}	12 ExtensionIdltestApiTest() : trunk_(version_info::Channel::UNKNOWN) {}

13 ~ExtensionIdltestApiTest() override {}	13 ~ExtensionIdltestApiTest() override {}

14	14

15 private:	15 private:

16 extensions::ScopedCurrentChannel trunk_;	16 extensions::ScopedCurrentChannel trunk_;

17 };	17 };

18	18

19 IN_PROC_BROWSER_TEST_F(ExtensionIdltestApiTest, IdlCompiler) {	19 IN_PROC_BROWSER_TEST_F(ExtensionIdltestApiTest, IdlCompiler) {

20 EXPECT_TRUE(RunExtensionSubtest("idltest/binary_data", "binary.html"));	20 EXPECT_TRUE(RunExtensionSubtest("idltest/binary_data", "binary.html"));

21 EXPECT_TRUE(RunExtensionSubtest("idltest/nocompile", "nocompile.html"));	21 EXPECT_TRUE(RunExtensionSubtest("idltest/nocompile", "nocompile.html"));

22 };	22 };

OLD	NEW