third_party/mesa/BUILD.gn - Issue 1257583007: Revert of Enable C4018 globally for the GN build, and disable per-target.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/mesa/BUILD.gn

Issue 1257583007: Revert of Enable C4018 globally for the GN build, and disable per-target. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/mesa/BUILD.gn

diff --git a/third_party/mesa/BUILD.gn b/third_party/mesa/BUILD.gn

index f0064626292cbc14a0bc7b5186f3d327dee2c0cf..de0a6a6d1ac1304232d680dcd065f64ad51fdbb2 100644

--- a/third_party/mesa/BUILD.gn

+++ b/third_party/mesa/BUILD.gn

@@ -125,7 +125,6 @@

cflags += [

"-Wno-tautological-constant-out-of-range-compare",

"-Wno-mismatched-tags", # Fixed upstream.

# mesa's STATIC_ASSERT() macro expands to an ununused typedef.

"-Wno-unused-local-typedef",

]

@@ -135,7 +134,6 @@

# Mesa is ever rolled and the warnings are fixed.

cflags += [

"/wd4005", # Macro defined twice.

- "/wd4018", # Signed/unsigned mismatch in comparison.

"/wd4065", # Switch statement contains 'default' but no 'case' labels.

"/wd4090", # 'Operation' : different 'modifier' qualifiers

"/wd4099", # Type name struct-vs-class doesn't match.

« no previous file with comments | « third_party/libxml/BUILD.gn ('k') | third_party/protobuf/BUILD.gn » ('j') | no next file with comments »