Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Unified Diff: third_party/protobuf/BUILD.gn

Issue 1257583007: Revert of Enable C4018 globally for the GN build, and disable per-target. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/mesa/BUILD.gn ('k') | third_party/qcms/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/protobuf/BUILD.gn
diff --git a/third_party/protobuf/BUILD.gn b/third_party/protobuf/BUILD.gn
index 7d42a00dd6a9c36da573ed5c9b31528ec60410aa..0c57bd65c46710a94e5821bc09554f2893664092 100644
--- a/third_party/protobuf/BUILD.gn
+++ b/third_party/protobuf/BUILD.gn
@@ -77,11 +77,11 @@
protobuf_lite_cflags = []
if (is_win) {
protobuf_lite_cflags = [
- "/wd4018", # Signed/unsigned mismatch in comparison.
- "/wd4244", # Implicit conversion, possible loss of data.
- "/wd4355", # 'this' used in base member initializer list.
- "/wd4267", # Size_t to int truncation.
- "/wd4291", # No matching operator delete for a placement new.
+ "/wd4018", # signed/unsigned mismatch in comparison
+ "/wd4244", # implicit conversion, possible loss of data
+ "/wd4355", # 'this' used in base member initializer list
+ "/wd4267", # size_t to int truncation
+ "/wd4291", # no matching operator delete for a placement new
]
}
« no previous file with comments | « third_party/mesa/BUILD.gn ('k') | third_party/qcms/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698