Source/web/FrameLoaderClientImpl.h - Issue 1257583003: Make WebMediaPlayerClient inheritance private in HTMLMediaElement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/FrameLoaderClientImpl.h

Issue 1257583003: Make WebMediaPlayerClient inheritance private in HTMLMediaElement (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: address nit Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/FrameLoaderClientImpl.h

diff --git a/Source/web/FrameLoaderClientImpl.h b/Source/web/FrameLoaderClientImpl.h

index 31a7dc15095107da20af75ea6a9d1e6f22ae046a..3210612063883745f3c6c4b44de1c3494282818e 100644

--- a/Source/web/FrameLoaderClientImpl.h

+++ b/Source/web/FrameLoaderClientImpl.h

@@ -132,7 +132,7 @@ public:

const KURL& /* base_url */,

const Vector<WTF::String>& paramNames,

const Vector<WTF::String>& paramValues) override;

- PassOwnPtr<WebMediaPlayer> createWebMediaPlayer(HTMLMediaElement*, const WebURL&) override;

+ PassOwnPtr<WebMediaPlayer> createWebMediaPlayer(HTMLMediaElement&, const WebURL&, WebMediaPlayerClient*) override;

ObjectContentType objectContentType(

const KURL&, const WTF::String& mimeType, bool shouldPreferPlugInsForImages) override;

void didChangeScrollOffset() override;

« no previous file with comments | « Source/core/loader/FrameLoaderClient.h ('k') | Source/web/FrameLoaderClientImpl.cpp » ('j') | no next file with comments »