Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Unified Diff: Source/web/FrameLoaderClientImpl.cpp

Issue 1257583003: Make WebMediaPlayerClient inheritance private in HTMLMediaElement (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: address nit Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/FrameLoaderClientImpl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/FrameLoaderClientImpl.cpp
diff --git a/Source/web/FrameLoaderClientImpl.cpp b/Source/web/FrameLoaderClientImpl.cpp
index 3bb5bc95fb8667696f0288f74174ea952da54b66..8885c1bea329eddb6bb9b0024a2d5bef414fb7cf 100644
--- a/Source/web/FrameLoaderClientImpl.cpp
+++ b/Source/web/FrameLoaderClientImpl.cpp
@@ -780,19 +780,20 @@ PassRefPtrWillBeRawPtr<Widget> FrameLoaderClientImpl::createJavaAppletWidget(
}
PassOwnPtr<WebMediaPlayer> FrameLoaderClientImpl::createWebMediaPlayer(
- HTMLMediaElement* htmlMediaElement,
- const WebURL& url)
+ HTMLMediaElement& htmlMediaElement,
+ const WebURL& url,
+ WebMediaPlayerClient* client)
{
WebLocalFrameImpl* webFrame = WebLocalFrameImpl::fromFrame(
- htmlMediaElement->document().frame());
+ htmlMediaElement.document().frame());
if (!webFrame || !webFrame->client())
return nullptr;
- HTMLMediaElementEncryptedMedia& encryptedMedia = HTMLMediaElementEncryptedMedia::from(*htmlMediaElement);
+ HTMLMediaElementEncryptedMedia& encryptedMedia = HTMLMediaElementEncryptedMedia::from(htmlMediaElement);
return adoptPtr(webFrame->client()->createMediaPlayer(webFrame, url,
- htmlMediaElement,
- &encryptedMedia, encryptedMedia.contentDecryptionModule()));
+ client, &encryptedMedia,
+ encryptedMedia.contentDecryptionModule()));
}
ObjectContentType FrameLoaderClientImpl::objectContentType(
« no previous file with comments | « Source/web/FrameLoaderClientImpl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698