Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issue 1257443003: Remove Duplicate LayerTreeHostCommonTest on Main Thread (Closed)

Created:
5 years, 5 months ago by weiliangc
Modified:
5 years, 5 months ago
Reviewers:
enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Duplicate LayerTreeHostCommonTest on Main Thread Remove these two tests because there are compositor thread version of them that does the exact same thing. These tests are used to test for RenderSurfaceLayerList generation, which we are looking to only do on compositor thread. This deletes: LayerTreeHostCommonTest.SubtreeHidden_SingleLayer LayerTreeHostCommonTest.SubtreeHidden_TwoLayers BUG=502041, 504466 R=enne CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/6172036d2c7275b949346e051d4cafad9f1b3e21 Cr-Commit-Position: refs/heads/master@{#340184}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -117 lines) Patch
M cc/trees/layer_tree_host_common_unittest.cc View 2 chunks +0 lines, -117 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 6 (1 generated)
weiliangc
5 years, 5 months ago (2015-07-23 20:01:45 UTC) #1
enne (OOO)
lgtm
5 years, 5 months ago (2015-07-23 22:15:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1257443003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1257443003/1
5 years, 5 months ago (2015-07-23 22:16:04 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-23 22:21:38 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-07-23 22:22:16 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6172036d2c7275b949346e051d4cafad9f1b3e21
Cr-Commit-Position: refs/heads/master@{#340184}

Powered by Google App Engine
This is Rietveld 408576698