Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 1243373004: Move LayerTreeHostCommon Copy Request tests to use LayerTreeHostImpl (Closed)

Created:
5 years, 5 months ago by weiliangc
Modified:
5 years, 5 months ago
Reviewers:
enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@rmnonimpltest
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move LayerTreeHostCommon Copy Request tests to use LayerTreeHostImpl LayerTreeHostCommon tests how copy request affects draw by testing RenderSurfaceLayerList. We are moving RenderSurfaceLayerList generation to compositor thread only, thus moving these tests to use compositor thread's testing setup. Tests changed: LayerTreeHostCommonTest.SubtreeHiddenWithCopyRequest LayerTreeHostCommonTest.ClippedOutCopyRequest BUG=502041, 504466 R=enne CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/51fb255dda0cc4ed63d93d90df6e6f288ccfeb06 Cr-Commit-Position: refs/heads/master@{#340279}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -142 lines) Patch
M cc/trees/layer_tree_host_common_unittest.cc View 3 chunks +113 lines, -142 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 6 (1 generated)
weiliangc
Slightly more complicated but conceptually just s/Layer/LayerImpl/
5 years, 5 months ago (2015-07-23 21:34:04 UTC) #1
enne (OOO)
lgtm
5 years, 5 months ago (2015-07-23 22:15:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1243373004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1243373004/1
5 years, 5 months ago (2015-07-24 15:08:45 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-24 15:32:37 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-07-24 15:33:29 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/51fb255dda0cc4ed63d93d90df6e6f288ccfeb06
Cr-Commit-Position: refs/heads/master@{#340279}

Powered by Google App Engine
This is Rietveld 408576698