Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Unified Diff: remoting/android/java/src/org/chromium/chromoting/CardboardDesktopRenderer.java

Issue 1257283007: Voice input (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Enable voice input. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/android/java/src/org/chromium/chromoting/CardboardDesktopRenderer.java
diff --git a/remoting/android/java/src/org/chromium/chromoting/CardboardDesktopRenderer.java b/remoting/android/java/src/org/chromium/chromoting/CardboardDesktopRenderer.java
index a5db293d55078e1e9df2491058eb6abb51103158..305b63c1f03ccb6d24f2e1e1f0cd9a78b2712dbc 100644
--- a/remoting/android/java/src/org/chromium/chromoting/CardboardDesktopRenderer.java
+++ b/remoting/android/java/src/org/chromium/chromoting/CardboardDesktopRenderer.java
@@ -375,10 +375,8 @@ public class CardboardDesktopRenderer implements CardboardView.StereoRenderer {
return value;
}
- /**
- * Check whether user is looking at desktop or not.
- * This can be called on any thread.
- */
+
+ // This can be called on any thread.
Lambros 2015/08/05 00:25:52 Undo this change?
shichengfeng 2015/08/05 23:06:31 Done.
public boolean isLookingAtDesktop() {
synchronized (mEyePositionLock) {
return Math.abs(mEyePositionVector[0]) <= (mHalfDesktopWidth + EDGE_MARGIN)
@@ -386,6 +384,20 @@ public class CardboardDesktopRenderer implements CardboardView.StereoRenderer {
}
}
+ // This can be called on any thread.
Lambros 2015/08/05 00:25:52 I think Javadoc is better, since the method is pub
shichengfeng 2015/08/05 23:06:31 Done.
+ public boolean isLookingLeftToDesktop() {
Lambros 2015/08/05 00:31:14 s/To/Of/
shichengfeng 2015/08/05 23:06:31 Done.
+ synchronized (mEyePositionLock) {
+ return mEyePositionVector[0] >= (mHalfDesktopWidth + EDGE_MARGIN);
+ }
+ }
+
+ // This can be called on any thread.
+ public boolean isLookingRightToDesktop() {
Lambros 2015/08/05 00:25:52 Same here.
shichengfeng 2015/08/05 23:06:31 Done.
+ synchronized (mEyePositionLock) {
+ return mEyePositionVector[0] <= -(mHalfDesktopWidth + EDGE_MARGIN);
+ }
+ }
+
/**
* Get position on desktop where user is looking at.
*/

Powered by Google App Engine
This is Rietveld 408576698