Voice input

remoting/android/java/src/org/chromium/chromoting/CardboardDesktopRenderer.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chromoting;
 
 import android.content.Context;
 import android.graphics.Bitmap;
 import android.graphics.PointF;
 import android.opengl.GLES20;
@@ skipping 357 matching lines @@
         float min = (a > b) ? b : a;
         float max = (a > b) ? a : b;
         if (value < min) {
             value = min;
         } else if (value > max) {
             value = max;
         }
         return value;
     }
 
-    /**
-     * Check whether user is looking at desktop or not.
-     * This can be called on any thread.
-     */
+
+     // This can be called on any thread.

[Lambros, 2015/08/05 00:25:52]

Undo this change?

[shichengfeng, 2015/08/05 23:06:31]

Done.

     public boolean isLookingAtDesktop() {
         synchronized (mEyePositionLock) {
             return Math.abs(mEyePositionVector[0]) <= (mHalfDesktopWidth + EDGE_MARGIN)
                 && Math.abs(mEyePositionVector[1]) <= (HALF_DESKTOP_HEIGHT + EDGE_MARGIN);
         }
     }
 
+    // This can be called on any thread.

[Lambros, 2015/08/05 00:25:52]

I think Javadoc is better, since the method is public:
"Returns true if user is looking at the space to the left of the desktop. Can be
called on any thread."

[shichengfeng, 2015/08/05 23:06:31]

Done.

+    public boolean isLookingLeftToDesktop() {

[Lambros, 2015/08/05 00:31:14]

s/To/Of/

[shichengfeng, 2015/08/05 23:06:31]

Done.

+        synchronized (mEyePositionLock) {
+            return mEyePositionVector[0] >= (mHalfDesktopWidth + EDGE_MARGIN);
+        }
+    }
+
+    // This can be called on any thread.
+    public boolean isLookingRightToDesktop() {

[Lambros, 2015/08/05 00:25:52]

Same here.

[shichengfeng, 2015/08/05 23:06:31]

Done.

+        synchronized (mEyePositionLock) {
+            return mEyePositionVector[0] <= -(mHalfDesktopWidth + EDGE_MARGIN);
+        }
+    }
+
     /**
      * Get position on desktop where user is looking at.
      */
     private void getLookingPosition() {
         synchronized (mEyePositionLock) {
             if (Math.abs(mForwardVector[2]) < 0.00001f) {
                 mEyePositionVector[0] = Math.signum(mForwardVector[0]) * Float.MAX_VALUE;
                 mEyePositionVector[1] = Math.signum(mForwardVector[1]) * Float.MAX_VALUE;
             } else {
                 mEyePositionVector[0] = mForwardVector[0] * DESKTOP_POSITION_Z / mForwardVector[2];
@@ skipping 62 matching lines @@
                 -mHalfDesktopWidth, HALF_DESKTOP_HEIGHT, 0.0f,
                 -mHalfDesktopWidth, -HALF_DESKTOP_HEIGHT, 0.0f,
                 mHalfDesktopWidth, HALF_DESKTOP_HEIGHT, 0.0f,
                 -mHalfDesktopWidth, -HALF_DESKTOP_HEIGHT, 0.0f,
                 mHalfDesktopWidth, -HALF_DESKTOP_HEIGHT, 0.0f,
                 mHalfDesktopWidth, HALF_DESKTOP_HEIGHT, 0.0f
             });
         }
     }
 }