Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(52)

Issue 12570005: Update user gesture related code to the new WebKit API (Closed)

Created:
7 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
7 years, 7 months ago
CC:
chromium-reviews, jam, joi+watch-content_chromium.org, Aaron Boodman, scheib+watch_chromium.org, darin-cc_chromium.org, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Update user gesture related code to the new WebKit API Whether or not a user gesture is processed is not tied to a frame, so the methods to query it shouldn't be on frame either. BUG=none TEST=no functional change R=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186838

Patch Set 1 #

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -19 lines) Patch
M chrome/renderer/extensions/request_sender.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/renderer/extensions/webstore_bindings.cc View 1 3 chunks +3 lines, -1 line 0 comments Download
M content/renderer/notification_provider.cc View 1 3 chunks +3 lines, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 1 9 chunks +9 lines, -10 lines 0 comments Download
M content/renderer/render_view_mouse_lock_dispatcher.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M webkit/plugins/ppapi/ppapi_plugin_instance.cc View 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jochen (gone - plz use gerrit)
7 years, 7 months ago (2013-03-07 09:15:27 UTC) #1
darin (slow to review)
LGTM
7 years, 7 months ago (2013-03-07 20:38:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/12570005/4001
7 years, 7 months ago (2013-03-07 21:34:07 UTC) #3
commit-bot: I haz the power
7 years, 7 months ago (2013-03-08 01:18:19 UTC) #4
Message was sent while issue was closed.
Change committed as 186838

Powered by Google App Engine
This is Rietveld 408576698