Issue 12570005: Update user gesture related code to the new WebKit API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12570005: Update user gesture related code to the new WebKit API (Closed)

Created:
7 years, 9 months ago by jochen (gone - plz use gerrit)

Modified:
7 years, 9 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews, jam, joi+watch-content_chromium.org, Aaron Boodman, scheib+watch_chromium.org, darin-cc_chromium.org, chromium-apps-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Update user gesture related code to the new WebKit API Whether or not a user gesture is processed is not tied to a frame, so the methods to query it shouldn't be on frame either. BUG=none TEST=no functional change R=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186838

Patch Set 1 #

Patch Set 2 : updates #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -19 lines)			Patch
M	chrome/renderer/extensions/request_sender.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/renderer/extensions/webstore_bindings.cc	View	1	3 chunks	+3 lines, -1 line	0 comments	Download
M	content/renderer/notification_provider.cc	View	1	3 chunks	+3 lines, -1 line	0 comments	Download
M	content/renderer/render_view_impl.cc	View	1	9 chunks	+9 lines, -10 lines	0 comments	Download
M	content/renderer/render_view_mouse_lock_dispatcher.cc	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	webkit/plugins/ppapi/ppapi_plugin_instance.cc	View		3 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/12570005/4001

7 years, 9 months ago (2013-03-07 21:34:07 UTC) #3

Message was sent while issue was closed.

Change committed as 186838

Expand Messages | Collapse Messages