net/url_request/url_request_http_job.cc - Issue 12569007: Remove URL fragment from referrer HTTP header when opening link using "Open Link in New Tab" option.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/url_request/url_request_http_job.cc

Issue 12569007: Remove URL fragment from referrer HTTP header when opening link using "Open Link in New Tab" option. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: address code review comments, add UMA_HISTOGRAM Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/tab_contents/render_view_context_menu_browsertest.cc ('K') | « net/url_request/url_request.cc ('k') | net/url_request/url_request_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/url_request/url_request_http_job.cc

diff --git a/net/url_request/url_request_http_job.cc b/net/url_request/url_request_http_job.cc

index caf344c325363afafb7dd6ed1fa8c42306d93e41..ad112d8ab46178dc66d2622c6df81edc2ec6a745 100644

--- a/net/url_request/url_request_http_job.cc

+++ b/net/url_request/url_request_http_job.cc

@@ -869,7 +869,7 @@ void URLRequestHttpJob::Start() {

DCHECK(!transaction_.get());

// Ensure that we do not send username and password fields in the referrer.

pauljensen 2013/03/15 21:50:00 This comment doesn't make as much sense now that t

mef 2013/03/18 16:42:07 Done.

- GURL referrer(request_->GetSanitizedReferrer());

+ GURL referrer(request_->referrer());

request_info_.url = request_->url();

request_info_.method = request_->method();