Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Unified Diff: net/url_request/url_request_unittest.cc

Issue 12569007: Remove URL fragment from referrer HTTP header when opening link using "Open Link in New Tab" option. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: address code review comments, add UMA_HISTOGRAM Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/url_request/url_request_unittest.cc
diff --git a/net/url_request/url_request_unittest.cc b/net/url_request/url_request_unittest.cc
index 8ef10a853c89da14750260253cc58b37c36f1406..ad5ae4263bd32b89e29887000739e84295fa626e 100644
--- a/net/url_request/url_request_unittest.cc
+++ b/net/url_request/url_request_unittest.cc
@@ -1929,7 +1929,7 @@ TEST_F(URLRequestTest, DoNotOverrideReferrer) {
TestDelegate d;
URLRequest req(
test_server.GetURL("echoheader?Referer"), &d, &default_context_);
- req.set_referrer("http://foo.com/");
+ req.SetReferrer("http://foo.com/");
HttpRequestHeaders headers;
headers.SetHeader(HttpRequestHeaders::kReferer, "http://bar.com/");
@@ -2961,7 +2961,7 @@ TEST_F(URLRequestTestHTTP, HTTPSToHTTPRedirectNoRefererTest) {
TestDelegate d;
URLRequest req(https_test_server.GetURL(
"server-redirect?" + http_destination.spec()), &d, &default_context_);
- req.set_referrer("https://www.referrer.com/");
+ req.SetReferrer("https://www.referrer.com/");
req.Start();
MessageLoop::current()->Run();
@@ -3496,13 +3496,26 @@ TEST_F(URLRequestTestHTTP, NoUserPassInReferrer) {
TestDelegate d;
URLRequest req(
test_server_.GetURL("echoheader?Referer"), &d, &default_context_);
- req.set_referrer("http://user:pass@foo.com/");
+ req.SetReferrer("http://user:pass@foo.com/");
req.Start();
MessageLoop::current()->Run();
EXPECT_EQ(std::string("http://foo.com/"), d.data_received());
}
+TEST_F(URLRequestTestHTTP, NoFragmentInReferrer) {
+ ASSERT_TRUE(test_server_.Start());
+
+ TestDelegate d;
+ URLRequest req(
+ test_server_.GetURL("echoheader?Referer"), &d, &default_context_);
+ req.SetReferrer("http://foo.com/test#fragment");
+ req.Start();
+ MessageLoop::current()->Run();
+
+ EXPECT_EQ(std::string("http://foo.com/test"), d.data_received());
+}
+
TEST_F(URLRequestTestHTTP, CancelRedirect) {
ASSERT_TRUE(test_server_.Start());

Powered by Google App Engine
This is Rietveld 408576698