Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1256823010: Add a documentation link. (Closed)

Created:
5 years, 4 months ago by Avi (use Gerrit)
Modified:
5 years, 4 months ago
Reviewers:
felt
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a documentation link. BUG=none TEST=none Committed: https://crrev.com/e9a1df640ed99314c4a70ddca9e874f30d66df37 Cr-Commit-Position: refs/heads/master@{#341470}

Patch Set 1 #

Total comments: 2

Patch Set 2 : s #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/browser/ui/tab_helpers.h View 1 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
felt
lgtm % nit https://codereview.chromium.org/1256823010/diff/1/chrome/browser/ui/tab_helpers.h File chrome/browser/ui/tab_helpers.h (right): https://codereview.chromium.org/1256823010/diff/1/chrome/browser/ui/tab_helpers.h#newcode28 chrome/browser/ui/tab_helpers.h:28: // http://www.chromium.org/developers/design-documents/tab-helpers nit: https pls?
5 years, 4 months ago (2015-07-31 22:34:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1256823010/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1256823010/20001
5 years, 4 months ago (2015-08-01 21:33:14 UTC) #5
Avi (use Gerrit)
https://codereview.chromium.org/1256823010/diff/1/chrome/browser/ui/tab_helpers.h File chrome/browser/ui/tab_helpers.h (right): https://codereview.chromium.org/1256823010/diff/1/chrome/browser/ui/tab_helpers.h#newcode28 chrome/browser/ui/tab_helpers.h:28: // http://www.chromium.org/developers/design-documents/tab-helpers On 2015/07/31 22:34:10, felt wrote: > nit: ...
5 years, 4 months ago (2015-08-01 21:33:44 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-01 22:39:19 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-08-01 22:39:52 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/e9a1df640ed99314c4a70ddca9e874f30d66df37
Cr-Commit-Position: refs/heads/master@{#341470}

Powered by Google App Engine
This is Rietveld 408576698