Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Unified Diff: chrome/browser/ui/tab_helpers.h

Issue 1256823010: Add a documentation link. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: s Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/tab_helpers.h
diff --git a/chrome/browser/ui/tab_helpers.h b/chrome/browser/ui/tab_helpers.h
index 1c678f2b55a08b530b7c09e7db86c4f0b2ee0b15..7e32de6cf81a4dcf4ef225bce9c267d1e0859c80 100644
--- a/chrome/browser/ui/tab_helpers.h
+++ b/chrome/browser/ui/tab_helpers.h
@@ -25,6 +25,8 @@ class PrerenderContents;
// (or the equivalent on Android). The TabHelpers class allows specific classes
// to attach the set of tab helpers that is used for tab contents.
//
+// https://www.chromium.org/developers/design-documents/tab-helpers
+//
// TODO(avi): This list is rather large, and for most callers it's due to the
// fact that they need tab helpers attached early to deal with arbitrary
// content loaded into a WebContents that will later be added to the tabstrip.
@@ -50,6 +52,10 @@ class TabHelpers {
// the full set of tab helpers to deal with it.
friend class prerender::PrerenderContents;
+ // FYI: Do NOT add any more friends here. The functions above are the ONLY
+ // ones that need to call AttachTabHelpers; if you think you do, re-read the
+ // design document linked above, especially the section "Reusing tab helpers".
+
// Adopts the specified WebContents as a full-fledged browser tab, attaching
// all the associated tab helpers that are needed for the WebContents to
// serve in that role. It is safe to call this on a WebContents that was
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698