Chromium Code Reviews| Index: chrome/browser/web_dev_style/html_checker.py |
| diff --git a/chrome/browser/web_dev_style/html_checker.py b/chrome/browser/web_dev_style/html_checker.py |
| index 78015542d4e1bb5aceec74f4c0e4422009273db0..422b7852185410a6f833185faee07bc96a269034 100644 |
| --- a/chrome/browser/web_dev_style/html_checker.py |
| +++ b/chrome/browser/web_dev_style/html_checker.py |
| @@ -46,9 +46,9 @@ class HtmlChecker(object): |
| def I18nContentJavaScriptCaseCheck(self, line_number, line): |
| regex = self.input_api.re.compile(""" |
| - (?:^|\s) # start of line or whitespace |
| - i18n-content=" # i18n-content=" |
| - ([A-Z]|.*[_-].*") # starts with caps or contains '-' or '_' |
| + (?:^|\s) # start of line or whitespace |
| + i18n-content=" # i18n-content=" |
| + ([A-Z][^"]*|[^"]*[-_][^"]*)" # starts with caps or contains '-' or '_' |
|
tommycli
2015/07/23 20:27:27
Hey should we do use '*?' instead of '*'?
It seem
Dan Beam
2015/07/23 20:28:13
it doesn't matter. [^"] stops at quotes
tommycli
2015/07/23 20:29:38
Ah that's right.
|
| """, |
| self.input_api.re.VERBOSE) |
| return regex_check.RegexCheck(self.input_api.re, line_number, line, regex, |