Fix i18n-content HTML presubmit check

chrome/browser/web_dev_style/html_checker.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """
 Presubmit for Chromium HTML resources. See chrome/browser/PRESUBMIT.py.
 """
 
 import regex_check
 
@@ skipping 28 matching lines @@
         (<input [^>]*  # "<input " followed by anything but ">"
         type="button"  # type="button"
         [^>]*>)        # anything but ">" then ">"
         """,
         self.input_api.re.VERBOSE)
     return regex_check.RegexCheck(self.input_api.re, line_number, line, regex,
         'Use the button element instead of <input type="button">')
 
   def I18nContentJavaScriptCaseCheck(self, line_number, line):
     regex = self.input_api.re.compile("""
-        (?:^|\s)           # start of line or whitespace
-        i18n-content="     # i18n-content="
-        ([A-Z]|.*[_-].*")  # starts with caps or contains '-' or '_'
+        (?:^|\s)                      # start of line or whitespace
+        i18n-content="                # i18n-content="
+        ([A-Z][^"]*|[^"]*[-_][^"]*)"  # starts with caps or contains '-' or '_'

[tommycli, 2015/07/23 20:27:27]

Hey should we do use '*?' instead of '*'?

It seems that we should be non-greedy in this check.

[Dan Beam, 2015/07/23 20:28:13]

it doesn't matter.  [^"] stops at quotes

[tommycli, 2015/07/23 20:29:38]

Ah that's right.

         """,
         self.input_api.re.VERBOSE)
     return regex_check.RegexCheck(self.input_api.re, line_number, line, regex,
         "For i18n-content use javaScriptCase.")
 
   def LabelCheck(self, line_number, line):
     regex = self.input_api.re.compile("""
         (?:^|\s) # start of line or whitespace
         (for=)   # for=
         """,
@@ skipping 24 matching lines @@
             self.LabelCheck(line_number, line),
         ]))
 
       if errors:
         abs_local_path = f.AbsoluteLocalPath()
         file_indicator = 'Found HTML style issues in %s' % abs_local_path
         prompt_msg = file_indicator + '\n\n' + '\n'.join(errors) + '\n'
         results.append(self.output_api.PresubmitPromptWarning(prompt_msg))
 
     return results