Fix i18n-content HTML presubmit check

Fix i18n-content HTML presubmit check

It was accidentally flagging i18n-content="valid" attr="invalid_"
                                           ^^^^^^^^^^^^^^^^^^^^^
(meaning it was escaping attribute quotes).

Eventually this pile of regex should probably be replaced

R=tommycli@chromium.org
BUG=513441
Committed: https://crrev.com/30cdbc30cfdd157aa1e7956f375f8c0b8cb84b42
Cr-Commit-Position: refs/heads/master@{#340158}

[tommycli, 2015-07-23 20:27:28]

https://codereview.chromium.org/1256653002/diff/1/chrome/browser/web_dev_styl...
File chrome/browser/web_dev_style/html_checker.py (right):

https://codereview.chromium.org/1256653002/diff/1/chrome/browser/web_dev_styl...
chrome/browser/web_dev_style/html_checker.py:51: ([A-Z][^"]*|[^"]*[-_][^"]*)"  #
starts with caps or contains '-' or '_'
Hey should we do use '*?' instead of '*'?

It seems that we should be non-greedy in this check.

[Dan Beam, 2015-07-23 20:28:14]

https://codereview.chromium.org/1256653002/diff/1/chrome/browser/web_dev_styl...
File chrome/browser/web_dev_style/html_checker.py (right):

https://codereview.chromium.org/1256653002/diff/1/chrome/browser/web_dev_styl...
chrome/browser/web_dev_style/html_checker.py:51: ([A-Z][^"]*|[^"]*[-_][^"]*)"  #
starts with caps or contains '-' or '_'
On 2015/07/23 20:27:27, tommycli wrote:
> Hey should we do use '*?' instead of '*'?
> 
> It seems that we should be non-greedy in this check.

it doesn't matter.  [^"] stops at quotes

[tommycli, 2015-07-23 20:29:39]

lgtm

https://codereview.chromium.org/1256653002/diff/1/chrome/browser/web_dev_styl...
File chrome/browser/web_dev_style/html_checker.py (right):

https://codereview.chromium.org/1256653002/diff/1/chrome/browser/web_dev_styl...
chrome/browser/web_dev_style/html_checker.py:51: ([A-Z][^"]*|[^"]*[-_][^"]*)"  #
starts with caps or contains '-' or '_'
On 2015/07/23 20:28:13, Dan Beam wrote:
> On 2015/07/23 20:27:27, tommycli wrote:
> > Hey should we do use '*?' instead of '*'?
> > 
> > It seems that we should be non-greedy in this check.
> 
> it doesn't matter.  [^"] stops at quotes

Ah that's right.

[Dan Beam, 2015-07-23 20:32:21]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2015-07-23 20:33:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1256653002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1256653002/1

[commit-bot: I haz the power, 2015-07-23 20:42:34]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-07-23 20:43:38]

Patchset 1 (id:??) landed as
https://crrev.com/30cdbc30cfdd157aa1e7956f375f8c0b8cb84b42
Cr-Commit-Position: refs/heads/master@{#340158}