[Extension ServiceWorkers] Chrome: Passing v8::context to extensions dispatcher

content/public/renderer/content_renderer_client.h

Index: content/public/renderer/content_renderer_client.h
diff --git a/content/public/renderer/content_renderer_client.h b/content/public/renderer/content_renderer_client.h
index ebb7f445307927598c46d2a5b1a654482584b97f..f018ea8622d5b6703ef670727616ae4b2b9bb404 100644
--- a/content/public/renderer/content_renderer_client.h
+++ b/content/public/renderer/content_renderer_client.h
@@ -85,6 +85,10 @@ class CONTENT_EXPORT ContentRendererClient {
   // Notifies that a new RenderView has been created.
   virtual void RenderViewCreated(RenderView* render_view) {}
 
+  virtual void ServiceWorkerCreated() {}

[Devlin, 2015/07/30 21:31:08]

Are these used?

[annekao, 2015/07/30 22:54:18]

Removed.

+  virtual void ServiceWorkerContextInitialized() {}
+  virtual void ServiceWorkerDestroyed() {}
+
   // Returns the bitmap to show when a plugin crashed, or NULL for none.
   virtual SkBitmap* GetSadPluginBitmap();
 
@@ -297,6 +301,9 @@ class CONTENT_EXPORT ContentRendererClient {
   virtual void AddImageContextMenuProperties(
       const blink::WebURLResponse& response,
       std::map<std::string, std::string>* properties) {}
+
+  virtual void DidInitializeWorkerContext(v8::Local<v8::Context> context,

[Devlin, 2015/07/30 21:31:08]

Comment this method.
Also, I'd rename this to DidInitializeWorkerContextOnWorkerThread(), so that
it's apparent that it's on a different thread.

[annekao, 2015/07/30 22:54:18]

Done.

[Devlin, 2015/07/30 22:58:51]

The method still has no comment...

[annekao, 2015/07/30 23:57:39]

Oops, somehow missed the first line. Done.

+                                          const GURL& url){};
 };
 
 }  // namespace content